deepblue/GoogleDriveManagement
1
0
Fork 0
mirror of https://github.com/GAM-team/GAM.git synced 2025-07-10 06:33:34 +00:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

More bug/pylint cleanup (#1258)

Browse Source 
* More bug/pylint cleanup

* pylint cleanup groups.py

* Update GamCommands.txt
This commit is contained in:
Ross Scroggs
2020-09-30 13:56:42 -07:00
committed by GitHub
parent 02fa092775
commit b41ca0f0be
7 changed files with 19 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/gam/gapi/cloudidentity/groups.py
View File

@ -1,5 +1,3 @@
import csv
import gam
from gam.var import *
from gam import controlflow
@ -9,7 +7,6 @@ from gam import utils
from gam.gapi import errors as gapi_errors
from gam.gapi import cloudidentity as gapi_cloudidentity
from gam.gapi.directory import customer as gapi_directory_customer
from gam.gapi.directory import groups as gapi_directory_groups
def create():
@ -583,14 +580,13 @@ def update():
name = membership_email_to_id(ci, parent, users_email[0])
addRoles = []
removeRoles = []
new_role = {'role': role}
current_roles = gapi.call(ci.groups().memberships(),
'get',
name=name,
fields='roles').get('roles', [])
current_roles = [role['name'] for role in current_roles]
for crole in current_roles:
if crole != ROLE_MEMBER and crole != role:
if crole not in {ROLE_MEMBER, role}:
removeRoles.append(crole)
if role not in current_roles:
addRoles.append({'name': role})