deepblue/ipmitool
1
0
Fork 0
mirror of https://github.com/ipmitool/ipmitool.git synced 2025-05-10 10:37:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

ID:296 - Fix PSD size decoding

Browse Source 
Commit replaces size decoding code with code ported from "decode-dimms" Perl
script found in i2c-tools 3.0.3. Former code has reported incorrect size of DDR2
modules.

Patch-by: Alexander Amelkin
This commit is contained in:
Zdenek Styblik 2014-03-23 07:37:58 +01:00
parent ca5cc560f6
commit 02e4a0361c
1 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
lib/dimm_spd.c
View File

@ -719,7 +719,8 @@ const struct valstr jedec_id5_vals[] = {
int int
ipmi_spd_print(uint8_t *spd_data, int len) ipmi_spd_print(uint8_t *spd_data, int len)
{ {
int size; int k = 0;
int ii = 0;
if (len < 92) if (len < 92)
return -1; /* we need first 91 bytes to do our thing */ return -1; /* we need first 91 bytes to do our thing */
@ -802,8 +803,15 @@ ipmi_spd_print(uint8_t *spd_data, int len)
} }
else else
{ {
size = spd_data[5] * (spd_data[31] << 2); ii = (spd_data[3] & 0x0f) + (spd_data[4] & 0x0f) - 17;
printf(" Memory Size : %d MB\n", size); k = ((spd_data[5] & 0x7) + 1) * spd_data[17];
if(ii > 0 && ii <= 12 && k > 0) {
printf(" Memory Size : %d MB\n", ((1 << ii) * k));
} else {
printf(" Memory Size INVALID: %d, %d, %d, %d\n", spd_data[3],
spd_data[4], spd_data[5], spd_data[17]);
}
printf(" Voltage Intf : %s\n", printf(" Voltage Intf : %s\n",
val2str(spd_data[8], spd_voltage_vals)); val2str(spd_data[8], spd_voltage_vals));
printf(" Error Detect/Cor : %s\n", printf(" Error Detect/Cor : %s\n",