ID: 50 - ipmi_hpmfwupg needs a clean up

HpmfwupgAbortUpgrade() - simplify function.
This commit is contained in:
Zdenek Styblik 2013-10-10 11:29:40 +00:00
parent b803224398
commit 08f50ad301

View File

@ -1804,16 +1804,15 @@ HpmfwupgAbortUpgrade(struct ipmi_intf *intf,
req.msg.data = (unsigned char*)&pCtx->req; req.msg.data = (unsigned char*)&pCtx->req;
req.msg.data_len = sizeof(struct HpmfwupgAbortUpgradeReq); req.msg.data_len = sizeof(struct HpmfwupgAbortUpgradeReq);
rsp = HpmfwupgSendCmd(intf, req, NULL); rsp = HpmfwupgSendCmd(intf, req, NULL);
if (rsp) { if (rsp == NULL) {
if (rsp->ccode != 0x00) { lprintf(LOG_ERR, "Error - aborting upgrade.");
lprintf(LOG_NOTICE,"Error aborting upgrade"); return HPMFWUPG_ERROR;
lprintf(LOG_NOTICE, "compcode=0x%x: %s", }
rsp->ccode, if (rsp->ccode != 0x00) {
val2str(rsp->ccode, completion_code_vals)); lprintf(LOG_ERR, "Error aborting upgrade");
rc = HPMFWUPG_ERROR; lprintf(LOG_ERR, "compcode=0x%x: %s",
} rsp->ccode,
} else { val2str(rsp->ccode, completion_code_vals));
lprintf(LOG_NOTICE,"Error aborting upgrade\n");
rc = HPMFWUPG_ERROR; rc = HPMFWUPG_ERROR;
} }
return rc; return rc;