ID: 46 - ipmi_fwum needs some re-work

KfwumStartFirmwareUpgrade() - code formatting
This commit is contained in:
Zdenek Styblik 2013-10-26 19:13:43 +00:00
parent 043c42160e
commit 0a4a5cafbc

View File

@ -1126,41 +1126,38 @@ static tKFWUM_Status KfwumUploadFirmware(struct ipmi_intf * intf,
return(status); return(status);
} }
static tKFWUM_Status KfwumStartFirmwareUpgrade(struct ipmi_intf * intf) static tKFWUM_Status
KfwumStartFirmwareUpgrade(struct ipmi_intf *intf)
{ {
tKFWUM_Status status = KFWUM_STATUS_OK; tKFWUM_Status status = KFWUM_STATUS_OK;
struct ipmi_rs * rsp; struct ipmi_rs *rsp;
struct ipmi_rq req; struct ipmi_rq req;
unsigned char upgType = 0 ; /* Upgrade type, wait BMC shutdown */ /* Upgrade type, wait BMC shutdown */
unsigned char upgType = 0 ;
memset(&req, 0, sizeof(req)); memset(&req, 0, sizeof(req));
req.msg.netfn = IPMI_NETFN_FIRMWARE; req.msg.netfn = IPMI_NETFN_FIRMWARE;
req.msg.cmd = KFWUM_CMD_ID_START_FIRMWARE_UPDATE; req.msg.cmd = KFWUM_CMD_ID_START_FIRMWARE_UPDATE;
req.msg.data = (unsigned char *) &upgType; req.msg.data = (unsigned char *) &upgType;
req.msg.data_len = 1; req.msg.data_len = 1;
rsp = intf->sendrecv(intf, &req); rsp = intf->sendrecv(intf, &req);
if (rsp == NULL) {
if (!rsp) lprintf(LOG_ERR,
{ "Error in FWUM Firmware Start Firmware Upgrade Command");
printf("Error in FWUM Firmware Start Firmware Upgrade Command\n"); status = KFWUM_STATUS_ERROR;
status = KFWUM_STATUS_ERROR; } else if (rsp->ccode) {
} if (rsp->ccode == 0xd5) {
else if (rsp->ccode) lprintf(LOG_ERR,
{ "No firmware available for upgrade. Download Firmware first.");
if(rsp->ccode == 0xd5) } else {
{ lprintf(LOG_ERR,
printf("No firmware available for upgrade. Download Firmware first\n"); "FWUM Firmware Start Firmware Upgrade returned %x",
} rsp->ccode);
else }
{ status = KFWUM_STATUS_ERROR;
printf("FWUM Firmware Start Firmware Upgrade returned %x\n", }
rsp->ccode); return status;
}
status = KFWUM_STATUS_ERROR;
}
return status;
} }
#define TRACE_LOG_CHUNK_COUNT 7 #define TRACE_LOG_CHUNK_COUNT 7