deepblue/ipmitool
1
0
Fork 0
mirror of https://github.com/ipmitool/ipmitool.git synced 2025-05-10 18:47:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

The unified sensor reading code was incorrectly returning and converting

Browse Source 
a sensor reading when the reading/state unavailable bit was set.  This
change makes sure a valid readiing is never returned for a sensor marked
reading/state unavailable.
This commit is contained in:
Jim Mankovich 2012-07-23 14:52:57 +00:00
parent 5d960089c9
commit 0ef4c3e254
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
ipmitool/lib/ipmi_sdr.c
View File

@ -1464,15 +1464,19 @@ ipmi_sdr_read_sensor_value(struct ipmi_intf *intf,
sr.s_id, sensor->keys.sensor_num);
return &sr;
}
sr.s_reading_valid = 1;
sr.s_reading = rsp->data[0];
if ( !sr.s_reading_unavailable ) {
sr.s_reading_valid = 1;
sr.s_reading = rsp->data[0];
}
if (rsp->data_len > 2)
sr.s_data2 = rsp->data[2];
if (rsp->data_len > 3)
sr.s_data3 = rsp->data[3];
if (sdr_sensor_has_analog_reading(intf, &sr)) {
sr.s_has_analog_value = 1;
sr.s_a_val = sdr_convert_sensor_reading(sr.full, sr.s_reading);
if (sr.s_reading_valid) {
sr.s_a_val = sdr_convert_sensor_reading(sr.full, sr.s_reading);
}
/* determine units string with possible modifiers */
sr.s_a_units = ipmi_sdr_get_unit_string(sr.full->cmn.unit.pct,
sr.full->cmn.unit.modifier,