From 148d0e090494a77a96a6267c63ae94310fc7ba2d Mon Sep 17 00:00:00 2001 From: Zdenek Styblik Date: Tue, 23 Dec 2014 14:22:00 +0100 Subject: [PATCH] ID:354 - uint8_t >= 0 is always true, don't test it Commit removes test whether value is greater or equal to 0 in is_ipmi_channel_num(), because it's always true(and it makes compiler mad). --- lib/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/helper.c b/lib/helper.c index 2a7ca4c..f6c0f75 100644 --- a/lib/helper.c +++ b/lib/helper.c @@ -719,7 +719,7 @@ is_ipmi_channel_num(const char *argv_ptr, uint8_t *channel_ptr) return (-1); } if ((str2uchar(argv_ptr, channel_ptr) == 0) - && ((*channel_ptr >= 0x0 && *channel_ptr <= 0xB) + && (*channel_ptr <= 0xB || (*channel_ptr >= 0xE && *channel_ptr <= 0xF))) { return 0; }