deepblue/ipmitool
1
0
Fork 0
mirror of https://github.com/ipmitool/ipmitool.git synced 2025-05-10 18:47:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

be pedantic when checking for errors

Browse Source
This commit is contained in:
Duncan Laurie 2005-01-07 22:14:56 +00:00
parent db9614572b
commit 14ee3f2362
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
ipmitool/src/plugins/lan/lan.c
View File

@ -138,8 +138,9 @@ static const struct valstr ipmi_channel_medium_vals[] = {
static struct ipmi_rq_entry * static struct ipmi_rq_entry *
ipmi_req_add_entry(struct ipmi_intf * intf, struct ipmi_rq * req) ipmi_req_add_entry(struct ipmi_intf * intf, struct ipmi_rq * req)
{ {
struct ipmi_rq_entry * e = malloc(sizeof(struct ipmi_rq_entry)); struct ipmi_rq_entry * e;
e = malloc(sizeof(struct ipmi_rq_entry));
if (e == NULL) { if (e == NULL) {
lprintf(LOG_ERR, "ipmitool: malloc failure"); lprintf(LOG_ERR, "ipmitool: malloc failure");
return NULL; return NULL;
@ -424,8 +425,10 @@ ipmi_lan_poll_recv(struct ipmi_intf * intf)
struct ipmi_rs * rsp; struct ipmi_rs * rsp;
struct ipmi_rq_entry * entry; struct ipmi_rq_entry * entry;
int x=0, rv; int x=0, rv;
rsp = ipmi_lan_recv_packet(intf); rsp = ipmi_lan_recv_packet(intf);
while (rsp) {
while (rsp != NULL) {
/* parse response headers */ /* parse response headers */
memcpy(&rmcp_rsp, rsp->data, 4); memcpy(&rmcp_rsp, rsp->data, 4);
@ -1359,7 +1362,7 @@ int ipmi_lan_open(struct ipmi_intf * intf)
if (s->privlvl == 0) if (s->privlvl == 0)
s->privlvl = IPMI_SESSION_PRIV_ADMIN; s->privlvl = IPMI_SESSION_PRIV_ADMIN;
if (strlen(s->hostname) == 0) { if (s->hostname == NULL || strlen(s->hostname) == 0) {
lprintf(LOG_ERR, "No hostname specified!"); lprintf(LOG_ERR, "No hostname specified!");
return -1; return -1;
} }