deepblue/ipmitool
1
0
Fork 0
mirror of https://github.com/ipmitool/ipmitool.git synced 2025-05-10 18:47:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

3600963 leak and failed random future note

Browse Source
This commit is contained in:
Ales Ledvinka 2013-01-16 12:15:10 +00:00
parent 3f9b728e57
commit 28f93df807
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
ipmitool/src/plugins/lan/lan.c
View File

@ -206,8 +206,11 @@ get_random(void *data, int len)
int fd = open("/dev/urandom", O_RDONLY); int fd = open("/dev/urandom", O_RDONLY);
int rv; int rv;
if (fd < 0 || len < 0) if (fd < 0)
return errno; return errno;
if (len < 0)
close(fd);
return errno; /* XXX: ORLY? */
rv = read(fd, data, len); rv = read(fd, data, len);
@ -1276,6 +1279,8 @@ ipmi_lan_send_sol_payload(struct ipmi_intf * intf,
} }
} }
if (msg != NULL)
free(msg);
return rsp; return rsp;
} }