From 3018b229b1fad4be7be62e8bd2e5e207d80acd37 Mon Sep 17 00:00:00 2001 From: Zdenek Styblik Date: Wed, 21 Nov 2012 09:07:30 +0000 Subject: [PATCH] ID: 3588726 - % ipmitool sol payload status ...; segfaults on no rsp Commit fixes segafult in ipmi_sol_payload_access_status in 'lib/ipmi_sol.c' when no response is received. This is caused by passing NULL to lprintf() as parameter, resp. accessing response data that aren't there. Reported by: Ales Ledvinka --- ipmitool/lib/ipmi_sol.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ipmitool/lib/ipmi_sol.c b/ipmitool/lib/ipmi_sol.c index 47288d8..7569613 100644 --- a/ipmitool/lib/ipmi_sol.c +++ b/ipmitool/lib/ipmi_sol.c @@ -163,8 +163,7 @@ ipmi_sol_payload_access_status(struct ipmi_intf * intf, rsp = intf->sendrecv(intf, &req); if (rsp == NULL) { - lprintf(LOG_ERR, "Error: Unexpected data length (%d) received", - rsp->data_len); + lprintf(LOG_ERR, "No valid response received."); return -1; }