From 384618d1bc62b5ccf036e7562614249a332b365f Mon Sep 17 00:00:00 2001 From: Zdenek Styblik Date: Sun, 2 Jun 2013 12:58:47 +0000 Subject: [PATCH] ID: 3612237 - If DCMI command fails, incorrect completion code is printed If any DCMI command fails, the function chk_rsp() in ipmi_dcmi.c displays the incorrect byte as the completion code. $ ipmitool dcmi power activate DCMI request failed because: Unspecified error (dc) The "dc" value printed is actually the "Group extension identification" byte which *always* has the value 0xdc for DCMI responses. Commit for Rob Swindell --- ipmitool/lib/ipmi_dcmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ipmitool/lib/ipmi_dcmi.c b/ipmitool/lib/ipmi_dcmi.c index 0477983..84c6d9a 100755 --- a/ipmitool/lib/ipmi_dcmi.c +++ b/ipmitool/lib/ipmi_dcmi.c @@ -379,11 +379,11 @@ static int chk_rsp(struct ipmi_rs * rsp) { */ if ((rsp->ccode >= 0x80) && (rsp->ccode <= 0x8F)) { lprintf(LOG_ERR, "\n DCMI request failed because: %s (%x)", - val2str(rsp->ccode, dcmi_ccode_vals), rsp->data[0]); + val2str(rsp->ccode, dcmi_ccode_vals), rsp->ccode); return 1; } else if (rsp->ccode > 0) { lprintf(LOG_ERR, "\n DCMI request failed because: %s (%x)", - val2str(rsp->ccode, completion_code_vals), rsp->data[0]); + val2str(rsp->ccode, completion_code_vals), rsp->ccode); return 1; }