open: fix whitespace

Apply whitespace fixes via clang-format-6.0 to src/plugins/open/open.c
to cleanup spaces and fixup line lengths, etc.

Signed-off-by: Patrick Venture <venture@google.com>
This commit is contained in:
Patrick Venture 2018-11-26 10:26:25 -08:00 committed by Alexander Amelkin
parent 08348f1b72
commit 3bfa1da201

View File

@ -88,8 +88,9 @@
extern int verbose; extern int verbose;
static int static
ipmi_openipmi_open(struct ipmi_intf * intf) int
ipmi_openipmi_open(struct ipmi_intf *intf)
{ {
char ipmi_dev[16]; char ipmi_dev[16];
char ipmi_devfs[16]; char ipmi_devfs[16];
@ -112,7 +113,7 @@ ipmi_openipmi_open(struct ipmi_intf * intf)
} }
if (intf->fd < 0) { if (intf->fd < 0) {
lperror(LOG_ERR, "Could not open device at %s or %s or %s", lperror(LOG_ERR, "Could not open device at %s or %s or %s",
ipmi_dev, ipmi_devfs , ipmi_devfs2); ipmi_dev, ipmi_devfs, ipmi_devfs2);
return -1; return -1;
} }
} }
@ -126,20 +127,21 @@ ipmi_openipmi_open(struct ipmi_intf * intf)
intf->opened = 1; intf->opened = 1;
/* This is never set to 0, the default is IPMI_BMC_SLAVE_ADDR */ /* This is never set to 0, the default is IPMI_BMC_SLAVE_ADDR */
if (intf->my_addr != 0) { if (intf->my_addr != 0) {
if (intf->set_my_addr(intf, intf->my_addr) < 0) { if (intf->set_my_addr(intf, intf->my_addr) < 0) {
lperror(LOG_ERR, "Could not set IPMB address"); lperror(LOG_ERR, "Could not set IPMB address");
return -1; return -1;
} }
lprintf(LOG_DEBUG, "Set IPMB address to 0x%x", lprintf(LOG_DEBUG, "Set IPMB address to 0x%x", intf->my_addr);
intf->my_addr );
} }
intf->manufacturer_id = ipmi_get_oem(intf); intf->manufacturer_id = ipmi_get_oem(intf);
return intf->fd; return intf->fd;
} }
static int
static
int
ipmi_openipmi_set_my_addr(struct ipmi_intf *intf, uint8_t addr) ipmi_openipmi_set_my_addr(struct ipmi_intf *intf, uint8_t addr)
{ {
unsigned int a = addr; unsigned int a = addr;
@ -151,8 +153,9 @@ ipmi_openipmi_set_my_addr(struct ipmi_intf *intf, uint8_t addr)
return 0; return 0;
} }
static void static
ipmi_openipmi_close(struct ipmi_intf * intf) void
ipmi_openipmi_close(struct ipmi_intf *intf)
{ {
if (intf->fd >= 0) { if (intf->fd >= 0) {
close(intf->fd); close(intf->fd);
@ -163,8 +166,9 @@ ipmi_openipmi_close(struct ipmi_intf * intf)
intf->manufacturer_id = IPMI_OEM_UNKNOWN; intf->manufacturer_id = IPMI_OEM_UNKNOWN;
} }
static struct ipmi_rs * static
ipmi_openipmi_send_cmd(struct ipmi_intf * intf, struct ipmi_rq * req) struct ipmi_rs *
ipmi_openipmi_send_cmd(struct ipmi_intf *intf, struct ipmi_rq *req)
{ {
struct ipmi_recv recv; struct ipmi_recv recv;
struct ipmi_addr addr; struct ipmi_addr addr;
@ -181,11 +185,10 @@ ipmi_openipmi_send_cmd(struct ipmi_intf * intf, struct ipmi_rq * req)
static int curr_seq = 0; static int curr_seq = 0;
fd_set rset; fd_set rset;
uint8_t * data = NULL; uint8_t *data = NULL;
int data_len = 0; int data_len = 0;
int retval = 0; int retval = 0;
if (!intf || !req) if (!intf || !req)
return NULL; return NULL;
@ -197,13 +200,12 @@ ipmi_openipmi_send_cmd(struct ipmi_intf * intf, struct ipmi_rq * req)
if (verbose > 2) { if (verbose > 2) {
fprintf(stderr, "OpenIPMI Request Message Header:\n"); fprintf(stderr, "OpenIPMI Request Message Header:\n");
fprintf(stderr, " netfn = 0x%x\n", req->msg.netfn ); fprintf(stderr, " netfn = 0x%x\n", req->msg.netfn);
fprintf(stderr, " cmd = 0x%x\n", req->msg.cmd); fprintf(stderr, " cmd = 0x%x\n", req->msg.cmd);
printbuf(req->msg.data, req->msg.data_len, "OpenIPMI Request Message Data"); printbuf(req->msg.data, req->msg.data_len,
"OpenIPMI Request Message Data");
} }
/* /*
* setup and send message * setup and send message
*/ */
@ -211,111 +213,116 @@ ipmi_openipmi_send_cmd(struct ipmi_intf * intf, struct ipmi_rq * req)
memset(&_req, 0, sizeof(struct ipmi_req)); memset(&_req, 0, sizeof(struct ipmi_req));
if (intf->target_addr != 0 && if (intf->target_addr != 0 &&
intf->target_addr != intf->my_addr) { intf->target_addr != intf->my_addr)
{
/* use IPMB address if needed */ /* use IPMB address if needed */
ipmb_addr.slave_addr = intf->target_addr; ipmb_addr.slave_addr = intf->target_addr;
ipmb_addr.lun = req->msg.lun; ipmb_addr.lun = req->msg.lun;
lprintf(LOG_DEBUG, "Sending request 0x%x to " lprintf(LOG_DEBUG,
"IPMB target @ 0x%x:0x%x (from 0x%x)", "Sending request 0x%x to "
req->msg.cmd, "IPMB target @ 0x%x:0x%x (from 0x%x)",
intf->target_addr,intf->target_channel, intf->my_addr); req->msg.cmd, intf->target_addr, intf->target_channel,
intf->my_addr);
if(intf->transit_addr != 0 && intf->transit_addr != intf->my_addr) { if (intf->transit_addr != 0 &&
uint8_t index = 0; intf->transit_addr != intf->my_addr)
{
uint8_t index = 0;
lprintf(LOG_DEBUG, "Encapsulating data sent to " lprintf(LOG_DEBUG,
"end target [0x%02x,0x%02x] using transit [0x%02x,0x%02x] from 0x%x ", "Encapsulating data sent to "
(0x40 | intf->target_channel), "end target [0x%02x,0x%02x] using "
intf->target_addr, "transit [0x%02x,0x%02x] from 0x%x ",
intf->transit_channel, (0x40 | intf->target_channel),
intf->transit_addr, intf->target_addr,
intf->my_addr intf->transit_channel,
); intf->transit_addr,
intf->my_addr);
/* Convert Message to 'Send Message' */ /* Convert Message to 'Send Message' */
/* Supplied req : req , internal req : _req */ /* Supplied req : req , internal req : _req */
if (verbose > 4) { if (verbose > 4) {
fprintf(stderr, "Converting message:\n"); fprintf(stderr, "Converting message:\n");
fprintf(stderr, " netfn = 0x%x\n", req->msg.netfn ); fprintf(stderr, " netfn = 0x%x\n", req->msg.netfn);
fprintf(stderr, " cmd = 0x%x\n", req->msg.cmd); fprintf(stderr, " cmd = 0x%x\n", req->msg.cmd);
if (req->msg.data && req->msg.data_len) { if (req->msg.data && req->msg.data_len) {
fprintf(stderr, " data_len = %d\n", req->msg.data_len); fprintf(stderr, " data_len = %d\n", req->msg.data_len);
fprintf(stderr, " data = %s\n", fprintf(stderr, " data = %s\n",
buf2str(req->msg.data,req->msg.data_len)); buf2str(req->msg.data, req->msg.data_len));
} }
} }
/* Modify target address to use 'transit' instead */ /* Modify target address to use 'transit' instead */
ipmb_addr.slave_addr = intf->transit_addr; ipmb_addr.slave_addr = intf->transit_addr;
ipmb_addr.channel = intf->transit_channel; ipmb_addr.channel = intf->transit_channel;
/* FIXME backup "My address" */ /* FIXME backup "My address" */
data_len = req->msg.data_len + 8; data_len = req->msg.data_len + 8;
data = malloc(data_len); data = malloc(data_len);
if (!data) { if (!data) {
lprintf(LOG_ERR, "ipmitool: malloc failure"); lprintf(LOG_ERR, "ipmitool: malloc failure");
return NULL; return NULL;
} }
memset(data, 0, data_len); memset(data, 0, data_len);
data[index++] = (0x40|intf->target_channel); data[index++] = (0x40 | intf->target_channel);
data[index++] = intf->target_addr; data[index++] = intf->target_addr;
data[index++] = ( req->msg.netfn << 2 ) | req->msg.lun ; data[index++] = (req->msg.netfn << 2) | req->msg.lun;
data[index++] = ipmi_csum(data+1, 2); data[index++] = ipmi_csum(data + 1, 2);
data[index++] = 0xFF; /* normally 0x20 , overwritten by IPMC */ data[index++] = 0xFF; /* normally 0x20 , overwritten by IPMC */
data[index++] = ( (0) << 2) | 0 ; /* FIXME */ data[index++] = ((0) << 2) | 0; /* FIXME */
data[index++] = req->msg.cmd; data[index++] = req->msg.cmd;
memcpy( (data+index) , req->msg.data, req->msg.data_len); memcpy((data + index), req->msg.data, req->msg.data_len);
index += req->msg.data_len; index += req->msg.data_len;
data[index++] = ipmi_csum( (data+4),(req->msg.data_len + 3) ); data[index++] = ipmi_csum((data + 4), (req->msg.data_len + 3));
if (verbose > 4) { if (verbose > 4) {
fprintf(stderr, "Encapsulated message:\n"); fprintf(stderr, "Encapsulated message:\n");
fprintf(stderr, " netfn = 0x%x\n", IPMI_NETFN_APP ); fprintf(stderr, " netfn = 0x%x\n", IPMI_NETFN_APP);
fprintf(stderr, " cmd = 0x%x\n", 0x34 ); fprintf(stderr, " cmd = 0x%x\n", 0x34);
if (data && data_len) { if (data && data_len) {
fprintf(stderr, " data_len = %d\n", data_len); fprintf(stderr, " data_len = %d\n", data_len);
fprintf(stderr, " data = %s\n", fprintf(stderr, " data = %s\n",
buf2str(data,data_len)); buf2str(data, data_len));
} }
} }
} }
_req.addr = (unsigned char *) &ipmb_addr; _req.addr = (unsigned char *)&ipmb_addr;
_req.addr_len = sizeof(ipmb_addr); _req.addr_len = sizeof(ipmb_addr);
} else { } else {
/* otherwise use system interface */ /* otherwise use system interface */
lprintf(LOG_DEBUG+2, "Sending request 0x%x to " lprintf(LOG_DEBUG + 2, "Sending request 0x%x to System Interface",
"System Interface", req->msg.cmd); req->msg.cmd);
bmc_addr.lun = req->msg.lun; bmc_addr.lun = req->msg.lun;
_req.addr = (unsigned char *) &bmc_addr; _req.addr = (unsigned char *)&bmc_addr;
_req.addr_len = sizeof(bmc_addr); _req.addr_len = sizeof(bmc_addr);
} }
_req.msgid = curr_seq++; _req.msgid = curr_seq++;
/* In case of a bridge request */ /* In case of a bridge request */
if (data && data_len != 0) { if (data && data_len != 0) {
_req.msg.data = data; _req.msg.data = data;
_req.msg.data_len = data_len; _req.msg.data_len = data_len;
_req.msg.netfn = IPMI_NETFN_APP; _req.msg.netfn = IPMI_NETFN_APP;
_req.msg.cmd = 0x34; _req.msg.cmd = 0x34;
} else { } else {
_req.msg.data = req->msg.data; _req.msg.data = req->msg.data;
_req.msg.data_len = req->msg.data_len; _req.msg.data_len = req->msg.data_len;
_req.msg.netfn = req->msg.netfn; _req.msg.netfn = req->msg.netfn;
_req.msg.cmd = req->msg.cmd; _req.msg.cmd = req->msg.cmd;
} }
if (ioctl(intf->fd, IPMICTL_SEND_COMMAND, &_req) < 0) { if (ioctl(intf->fd, IPMICTL_SEND_COMMAND, &_req) < 0) {
lperror(LOG_ERR, "Unable to send command"); lperror(LOG_ERR, "Unable to send command");
if (data) { if (data) {
free(data); free(data);
data = NULL; data = NULL;
} }
return NULL; return NULL;
} }
/* /*
@ -323,11 +330,11 @@ ipmi_openipmi_send_cmd(struct ipmi_intf * intf, struct ipmi_rq * req)
*/ */
if (intf->noanswer) { if (intf->noanswer) {
if (data) { if (data) {
free(data); free(data);
data = NULL; data = NULL;
} }
return NULL; return NULL;
} }
FD_ZERO(&rset); FD_ZERO(&rset);
@ -335,15 +342,15 @@ ipmi_openipmi_send_cmd(struct ipmi_intf * intf, struct ipmi_rq * req)
read_timeout.tv_sec = IPMI_OPENIPMI_READ_TIMEOUT; read_timeout.tv_sec = IPMI_OPENIPMI_READ_TIMEOUT;
read_timeout.tv_usec = 0; read_timeout.tv_usec = 0;
do { do {
retval = select(intf->fd+1, &rset, NULL, NULL, &read_timeout); retval = select(intf->fd + 1, &rset, NULL, NULL, &read_timeout);
} while (retval < 0 && errno == EINTR); } while (retval < 0 && errno == EINTR);
if (retval < 0) { if (retval < 0) {
lperror(LOG_ERR, "I/O Error"); lperror(LOG_ERR, "I/O Error");
if (data) { if (data) {
free(data); free(data);
data = NULL; data = NULL;
} }
return NULL; return NULL;
} else if (retval == 0) { } else if (retval == 0) {
lprintf(LOG_ERR, "No data available"); lprintf(LOG_ERR, "No data available");
if (data) { if (data) {
@ -353,71 +360,74 @@ ipmi_openipmi_send_cmd(struct ipmi_intf * intf, struct ipmi_rq * req)
return NULL; return NULL;
} }
if (FD_ISSET(intf->fd, &rset) == 0) { if (FD_ISSET(intf->fd, &rset) == 0) {
lprintf(LOG_ERR, "No data available"); lprintf(LOG_ERR, "No data available");
if (data) { if (data) {
free(data); free(data);
data = NULL; data = NULL;
} }
return NULL; return NULL;
} }
recv.addr = (unsigned char *) &addr; recv.addr = (unsigned char *)&addr;
recv.addr_len = sizeof(addr); recv.addr_len = sizeof(addr);
recv.msg.data = rsp.data; recv.msg.data = rsp.data;
recv.msg.data_len = sizeof(rsp.data); recv.msg.data_len = sizeof(rsp.data);
/* get data */ /* get data */
if (ioctl(intf->fd, IPMICTL_RECEIVE_MSG_TRUNC, &recv) < 0) { if (ioctl(intf->fd, IPMICTL_RECEIVE_MSG_TRUNC, &recv) < 0) {
lperror(LOG_ERR, "Error receiving message"); lperror(LOG_ERR, "Error receiving message");
if (errno != EMSGSIZE) { if (errno != EMSGSIZE) {
if (data) { if (data) {
free(data); free(data);
data = NULL; data = NULL;
} }
return NULL; return NULL;
} }
} }
if (verbose > 4) { if (verbose > 4) {
fprintf(stderr, "Got message:"); fprintf(stderr, "Got message:");
fprintf(stderr, " type = %d\n", recv.recv_type); fprintf(stderr, " type = %d\n", recv.recv_type);
fprintf(stderr, " channel = 0x%x\n", addr.channel); fprintf(stderr, " channel = 0x%x\n", addr.channel);
fprintf(stderr, " msgid = %ld\n", recv.msgid); fprintf(stderr, " msgid = %ld\n", recv.msgid);
fprintf(stderr, " netfn = 0x%x\n", recv.msg.netfn); fprintf(stderr, " netfn = 0x%x\n", recv.msg.netfn);
fprintf(stderr, " cmd = 0x%x\n", recv.msg.cmd); fprintf(stderr, " cmd = 0x%x\n", recv.msg.cmd);
if (recv.msg.data && recv.msg.data_len) { if (recv.msg.data && recv.msg.data_len) {
fprintf(stderr, " data_len = %d\n", recv.msg.data_len); fprintf(stderr, " data_len = %d\n", recv.msg.data_len);
fprintf(stderr, " data = %s\n", fprintf(stderr, " data = %s\n",
buf2str(recv.msg.data, recv.msg.data_len)); buf2str(recv.msg.data, recv.msg.data_len));
} }
} }
if(intf->transit_addr != 0 && intf->transit_addr != intf->my_addr) { if (intf->transit_addr != 0 && intf->transit_addr != intf->my_addr) {
/* ipmb_addr.transit_slave_addr = intf->transit_addr; */ /* ipmb_addr.transit_slave_addr = intf->transit_addr; */
lprintf(LOG_DEBUG, "Decapsulating data received from transit " lprintf(LOG_DEBUG,
"IPMB target @ 0x%x", intf->transit_addr); "Decapsulating data received from transit "
"IPMB target @ 0x%x",
intf->transit_addr);
/* comp code */ /* comp code */
/* Check data */ /* Check data */
if( recv.msg.data[0] == 0 ) { if (recv.msg.data[0] == 0) {
recv.msg.netfn = recv.msg.data[2] >> 2; recv.msg.netfn = recv.msg.data[2] >> 2;
recv.msg.cmd = recv.msg.data[6]; recv.msg.cmd = recv.msg.data[6];
recv.msg.data = memmove(recv.msg.data ,recv.msg.data+7 , recv.msg.data_len - 7); recv.msg.data = memmove(recv.msg.data, recv.msg.data + 7,
recv.msg.data_len -=8; recv.msg.data_len - 7);
recv.msg.data_len -= 8;
if (verbose > 4) { if (verbose > 4) {
fprintf(stderr, "Decapsulated message:\n"); fprintf(stderr, "Decapsulated message:\n");
fprintf(stderr, " netfn = 0x%x\n", recv.msg.netfn ); fprintf(stderr, " netfn = 0x%x\n", recv.msg.netfn);
fprintf(stderr, " cmd = 0x%x\n", recv.msg.cmd); fprintf(stderr, " cmd = 0x%x\n", recv.msg.cmd);
if (recv.msg.data && recv.msg.data_len) { if (recv.msg.data && recv.msg.data_len) {
fprintf(stderr, " data_len = %d\n", recv.msg.data_len); fprintf(stderr, " data_len = %d\n", recv.msg.data_len);
fprintf(stderr, " data = %s\n", fprintf(stderr, " data = %s\n",
buf2str(recv.msg.data,recv.msg.data_len)); buf2str(recv.msg.data, recv.msg.data_len));
} }
} }
} }
} }
/* save completion code */ /* save completion code */
@ -426,8 +436,8 @@ ipmi_openipmi_send_cmd(struct ipmi_intf * intf, struct ipmi_rq * req)
/* save response data for caller */ /* save response data for caller */
if (!rsp.ccode && rsp.data_len > 0) { if (!rsp.ccode && rsp.data_len > 0) {
memmove(rsp.data, rsp.data + 1, rsp.data_len); memmove(rsp.data, rsp.data + 1, rsp.data_len);
rsp.data[rsp.data_len] = 0; rsp.data[rsp.data_len] = 0;
} }
if (data) { if (data) {
@ -438,7 +448,8 @@ ipmi_openipmi_send_cmd(struct ipmi_intf * intf, struct ipmi_rq * req)
return &rsp; return &rsp;
} }
int ipmi_openipmi_setup(struct ipmi_intf * intf) int
ipmi_openipmi_setup(struct ipmi_intf *intf)
{ {
/* set default payload size */ /* set default payload size */
intf->max_request_data_size = IPMI_OPENIPMI_MAX_RQ_DATA_SIZE; intf->max_request_data_size = IPMI_OPENIPMI_MAX_RQ_DATA_SIZE;