deepblue/ipmitool
1
0
Fork 0
mirror of https://github.com/ipmitool/ipmitool.git synced 2025-05-10 18:47:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

ID: 3522740 - reading password from file is limited to 16byte passwords

Browse Source 
Reading password from file is no longer limited to 16bytes.

Reported-by: Dune Idaho
This commit is contained in:
Zdenek Styblik 2013-05-22 10:05:06 +00:00
parent d82a29d813
commit 44247a8743
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ipmitool/lib/ipmi_main.c
View File

@ -101,12 +101,13 @@ ipmi_password_file_read(char * filename)
char * pass = NULL; char * pass = NULL;
int l; int l;
pass = malloc(16); pass = malloc(21);
if (pass == NULL) { if (pass == NULL) {
lprintf(LOG_ERR, "ipmitool: malloc failure"); lprintf(LOG_ERR, "ipmitool: malloc failure");
return NULL; return NULL;
} }
memset(pass, 21, 0);
fp = ipmi_open_file_read((const char *)filename); fp = ipmi_open_file_read((const char *)filename);
if (fp == NULL) { if (fp == NULL) {
lprintf(LOG_ERR, "Unable to open password file %s", lprintf(LOG_ERR, "Unable to open password file %s",
@ -115,7 +116,7 @@ ipmi_password_file_read(char * filename)
} }
/* read in id */ /* read in id */
if (fgets(pass, 16, fp) == NULL) { if (fgets(pass, 21, fp) == NULL) {
lprintf(LOG_ERR, "Unable to read password from file %s", lprintf(LOG_ERR, "Unable to read password from file %s",
filename); filename);
fclose(fp); fclose(fp);