deepblue/ipmitool
1
0
Fork 0
mirror of https://github.com/ipmitool/ipmitool.git synced 2025-05-10 18:47:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

ID: 3608761 - 'lib/ipmi_main.c' - PICMG Get Device Locator was never run

Browse Source 
This code was moved to ipmi_main.c from open.c and in the change a bug
was introduced where the PICMG Get Device Locator command would not
be run unless the user explicitly set my_addr to 0 with the -m command.

The more sensible thing to do is to run this unless the user explictly
overrides it with the -m option.

Commit for Dan Gora
This commit is contained in:
Zdenek Styblik 2013-04-08 17:46:17 +00:00
parent 3687a6cbb8
commit 49a7ceee70
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ipmitool/lib/ipmi_main.c
View File

@ -364,7 +364,7 @@ ipmi_main(int argc, char ** argv,
uint8_t transit_addr = 0; uint8_t transit_addr = 0;
uint8_t transit_channel = 0; uint8_t transit_channel = 0;
uint8_t target_lun = 0; uint8_t target_lun = 0;
uint8_t my_addr = 0x20; uint8_t my_addr = 0;
uint16_t my_long_packet_size=0; uint16_t my_long_packet_size=0;
uint8_t my_long_packet_set=0; uint8_t my_long_packet_set=0;
uint8_t lookupbit = 0x10; /* use name-only lookup by default */ uint8_t lookupbit = 0x10; /* use name-only lookup by default */
@ -892,6 +892,9 @@ ipmi_main(int argc, char ** argv,
if (my_addr) { if (my_addr) {
ipmi_main_intf->my_addr = my_addr; ipmi_main_intf->my_addr = my_addr;
} else { } else {
/* Use the default for the payload source address */
my_addr = 0x20;
/* Check if PICMG extension is available to use the function /* Check if PICMG extension is available to use the function
* GetDeviceLocator to retreive i2c address PICMG hack to set * GetDeviceLocator to retreive i2c address PICMG hack to set
* right IPMB address, If extension is not supported, should * right IPMB address, If extension is not supported, should