From 4a462cd71493ff0b86ba9f7161e5e3b721091293 Mon Sep 17 00:00:00 2001 From: Zdenek Styblik Date: Wed, 8 Feb 2012 14:42:47 +0000 Subject: [PATCH] Change return type and value of find_lan_channel() in 'lib/ipmi_lanp.c' Changes return type from int to uint8 since returned value is being assigned into uint8_t. Changes return value from (-1) to 0, because of uint8_t. 0 is considered as an invalid LAN channel anyway, so there is no reason for returning (-1). --- ipmitool/lib/ipmi_lanp.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/ipmitool/lib/ipmi_lanp.c b/ipmitool/lib/ipmi_lanp.c index 6897bb3..81ae039 100644 --- a/ipmitool/lib/ipmi_lanp.c +++ b/ipmitool/lib/ipmi_lanp.c @@ -83,22 +83,22 @@ is_lan_channel(struct ipmi_intf * intf, uint8_t chan) /* find_lan_channel - Find first channel that is LAN * * return channel number if successful - * return -1 if no lan channel found + * return 0 if no lan channel found, which is not a valid LAN channel * * @intf: ipmi interface handle * @start: channel number to start searching from */ -static int -find_lan_channel(struct ipmi_intf * intf, int start) +static uint8_t +find_lan_channel(struct ipmi_intf * intf, uint8_t start) { - uint8_t chan; + uint8_t chan = 0; for (chan = start; chan < IPMI_CHANNEL_NUMBER_MAX; chan++) { - if (is_lan_channel(intf, chan)) { + if (!is_lan_channel(intf, chan)) { return chan; } } - return -1; + return 0; } /* get_lan_param_select - Query BMC for LAN parameter data