ID: 46 - ipmi_fwum needs some re-work

KfwumOutputInfo() -> printf_kfwum_info() + code formatting
This commit is contained in:
Zdenek Styblik 2013-10-26 19:15:15 +00:00
parent d5d86d4dcb
commit 4e2ac7d097

View File

@ -182,8 +182,8 @@ static tKFWUM_Status KfwumGetTraceLog(struct ipmi_intf * intf);
tKFWUM_Status ipmi_kfwum_checkfwcompat(tKFWUM_BoardInfo boardInfo, tKFWUM_Status ipmi_kfwum_checkfwcompat(tKFWUM_BoardInfo boardInfo,
tKFWUM_InFirmwareInfo firmInfo); tKFWUM_InFirmwareInfo firmInfo);
static void KfwumOutputInfo(tKFWUM_BoardInfo boardInfo, void printf_kfwum_info(tKFWUM_BoardInfo boardInfo,
tKFWUM_InFirmwareInfo firmInfo); tKFWUM_InFirmwareInfo firmInfo);
/* ipmi_fwum_main - entry point for this ipmitool mode /* ipmi_fwum_main - entry point for this ipmitool mode
@ -359,7 +359,7 @@ static void KfwumMain(struct ipmi_intf * intf, tKFWUM_Task task)
unsigned char notUsed; unsigned char notUsed;
KfwumGetInfo(intf, 0, &notUsed); KfwumGetInfo(intf, 0, &notUsed);
} }
KfwumOutputInfo(boardInfo,firmInfo); printf_kfwum_info(boardInfo,firmInfo);
} }
if ((status == KFWUM_STATUS_OK) if ((status == KFWUM_STATUS_OK)
&& ((task == KFWUM_TASK_UPGRADE) && ((task == KFWUM_TASK_UPGRADE)
@ -1423,12 +1423,16 @@ tKFWUM_Status ipmi_kfwum_checkfwcompat(tKFWUM_BoardInfo boardInfo,
} }
static void KfwumOutputInfo(tKFWUM_BoardInfo boardInfo, void
tKFWUM_InFirmwareInfo firmInfo) printf_kfwum_info(tKFWUM_BoardInfo boardInfo, tKFWUM_InFirmwareInfo firmInfo)
{ {
printf("Target Board Id : %u\n",boardInfo.boardId); printf(
printf("Target IANA number : %u\n",boardInfo.iana); "Target Board Id : %u\n", boardInfo.boardId);
printf("File Size : %lu bytes\n",firmInfo.fileSize); printf(
printf("Firmware Version : %d.%d%d SDR %d\n",firmInfo.versMajor, "Target IANA number : %u\n", boardInfo.iana);
firmInfo.versMinor, firmInfo.versSubMinor, firmInfo.sdrRev); printf(
"File Size : %lu bytes\n", firmInfo.fileSize);
printf(
"Firmware Version : %d.%d%d SDR %d\n", firmInfo.versMajor,
firmInfo.versMinor, firmInfo.versSubMinor, firmInfo.sdrRev);
} }