From 4f0967779e5c4716ee189ef2e552f5411c641e54 Mon Sep 17 00:00:00 2001 From: Zdenek Styblik Date: Fri, 25 Apr 2014 20:40:36 +0200 Subject: [PATCH] ID: 310 - lanplus retry regression The lanplus driver for has a bug in ipmi_lanplus_open_session(). There is an extra and undesired check for a null response (timeout). As a result, it returns 1 to the caller. The result of this is an occasional assertion. Commit mends this. Commit for Pat Donlin --- src/plugins/lanplus/lanplus.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/plugins/lanplus/lanplus.c b/src/plugins/lanplus/lanplus.c index 9cf3c5e..27b9610 100644 --- a/src/plugins/lanplus/lanplus.c +++ b/src/plugins/lanplus/lanplus.c @@ -2882,17 +2882,13 @@ ipmi_lanplus_open_session(struct ipmi_intf * intf) free(msg); msg = NULL; - if (!rsp) { - lprintf(LOG_WARNING, "Error sending open session message."); - return -1; - } - if (verbose) - lanplus_dump_open_session_response(rsp); - if (rsp == NULL ) { lprintf(LOG_DEBUG, "Timeout in open session response message."); return 2; } + if (verbose) + lanplus_dump_open_session_response(rsp); + if (rsp->payload.open_session_response.rakp_return_code != IPMI_RAKP_STATUS_NO_ERRORS) {