deepblue/ipmitool
1
0
Fork 0
mirror of https://github.com/ipmitool/ipmitool.git synced 2025-05-11 19:17:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix user priv bugs

Browse Source
This commit is contained in:
Duncan Laurie 2006-07-28 22:37:49 +00:00
parent 0d6fecc737
commit 50f36dd841
2 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ipmitool/lib/helper.c
View File

@ -398,8 +398,10 @@ ipmi_start_daemon(void)
chdir("/"); chdir("/");
umask(0); umask(0);
#if 0
for (fd=0; fd<64; fd++) for (fd=0; fd<64; fd++)
close(fd); close(fd);
#endif
open("/dev/null", O_RDWR); open("/dev/null", O_RDWR);
dup(0); dup(0);

14
ipmitool/lib/ipmi_user.c
View File

@ -349,18 +349,20 @@ ipmi_user_set_userpriv(
{ {
struct ipmi_rs *rsp; struct ipmi_rs *rsp;
struct ipmi_rq req; struct ipmi_rq req;
uint8_t msg_data[3]; uint8_t msg_data[4];
memset(&req, 0, sizeof(req)); memset(&req, 0, sizeof(req));
req.msg.netfn = IPMI_NETFN_APP; /* 0x06 */ req.msg.netfn = IPMI_NETFN_APP; /* 0x06 */
req.msg.cmd = IPMI_SET_USER_ACCESS; /* 0x43 */ req.msg.cmd = IPMI_SET_USER_ACCESS; /* 0x43 */
req.msg.data = msg_data; req.msg.data = msg_data;
req.msg.data_len = 3; req.msg.data_len = 4;
/* The channel number will remain constant throughout this function */ /* The channel number will remain constant throughout this function */
msg_data[0] = (channel & 0x0f); /* Do not change any bytes */ msg_data[0] = (channel & 0x0f);
msg_data[0] |= 0x90; /* enable ipmi messaging */
msg_data[1] = (user_id & 0x3f); msg_data[1] = (user_id & 0x3f);
msg_data[2] = (privLevel & 0x0f); msg_data[2] = (privLevel & 0x0f);
msg_data[3] = 0;
rsp = intf->sendrecv(intf, &req); rsp = intf->sendrecv(intf, &req);
@ -372,8 +374,8 @@ ipmi_user_set_userpriv(
} }
if (rsp->ccode > 0) if (rsp->ccode > 0)
{ {
lprintf(LOG_ERR, "Set Privilege Level command failed (user %d)", lprintf(LOG_ERR, "Set Privilege Level command failed (user %d): %s",
user_id); user_id, val2str(rsp->ccode, completion_code_vals));
return -1; return -1;
} }
@ -492,7 +494,7 @@ print_user_usage(void)
lprintf(LOG_NOTICE, " set password <user id> [<password>]"); lprintf(LOG_NOTICE, " set password <user id> [<password>]");
lprintf(LOG_NOTICE, " disable <user id>"); lprintf(LOG_NOTICE, " disable <user id>");
lprintf(LOG_NOTICE, " enable <user id>"); lprintf(LOG_NOTICE, " enable <user id>");
lprintf(LOG_NOTICE, " priv <user id> <privile level> [<channel number>]"); lprintf(LOG_NOTICE, " priv <user id> <privilege level> [<channel number>]");
lprintf(LOG_NOTICE, " test <user id> <16|20> [<password]>\n"); lprintf(LOG_NOTICE, " test <user id> <16|20> [<password]>\n");
} }