From 572f2df8bb113310a2c1dfffcb22a4b8a8bf19ff Mon Sep 17 00:00:00 2001 From: Duncan Laurie Date: Mon, 8 Mar 2004 20:31:26 +0000 Subject: [PATCH] repair memory leak on sent packets --- ipmitool/src/plugins/lan/lan.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/ipmitool/src/plugins/lan/lan.c b/ipmitool/src/plugins/lan/lan.c index 4947837..242e597 100644 --- a/ipmitool/src/plugins/lan/lan.c +++ b/ipmitool/src/plugins/lan/lan.c @@ -157,6 +157,8 @@ ipmi_req_remove_entry(unsigned char seq, unsigned char cmd) else ipmi_req_entries_tail = NULL; } + if (e->msg_data) + free(e->msg_data); free(e); } } @@ -666,7 +668,6 @@ ipmi_lan_send_cmd(struct ipmi_intf * intf, struct ipmi_rq * req) while (try < IPMI_LAN_RETRY) { if (ipmi_lan_send_packet(intf, entry->msg_data, entry->msg_len) < 0) { printf("ipmi_lan_send_cmd failed\n"); - free(entry->msg_data); return NULL; } @@ -683,9 +684,6 @@ ipmi_lan_send_cmd(struct ipmi_intf * intf, struct ipmi_rq * req) try++; } - free(entry->msg_data); - entry->msg_len = 0; - return rsp; }