From 5cf436056fe12b48d90fb7acecf7b8fb7cc3195a Mon Sep 17 00:00:00 2001 From: Thomas Renninger Date: Tue, 27 Apr 2021 20:54:23 +0200 Subject: [PATCH] Fix codefactor-io / CodeFactor warnings Use $(...) notation instead of legacy backticked `...`. (SC2006) --- contrib/bmc-snmp-proxy | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/contrib/bmc-snmp-proxy b/contrib/bmc-snmp-proxy index 9143c83..6e69e61 100644 --- a/contrib/bmc-snmp-proxy +++ b/contrib/bmc-snmp-proxy @@ -29,7 +29,7 @@ TRAPD_CONF="/etc/snmp/snmptrapd.conf" LOCKFILE="/var/lock/subsys/bmc-snmp-proxy" BMC_INFO="/run/bmc-info" -IPMITOOL=`which ipmitool` +IPMITOOL=$(which ipmitool) #Default config BMC_COMMUNITY="public" @@ -158,7 +158,7 @@ pick_alert_dest() { test_ip="$1" # We have 4 IPv4 and 4 IPv6 alert dest. We will set IPv4 for now. - for ALERT_DEST in `seq 1 4` + for ALERT_DEST in $(seq 1 4) do temp_ip=$(${IPMITOOL} lan alert print ${CHANNEL} ${ALERT_DEST}\ 2>/dev/null| sed -n "s#^Alert IP Address.*: ##p") @@ -178,7 +178,7 @@ config_bmc_alert_dest() { # call with enable|disable # Pick the first active LAN channel - for CHANNEL in `seq 1 14` + for CHANNEL in $(seq 1 14) do [ $(${IPMITOOL} -I open channel info ${CHANNEL} 2>/dev/null \ | grep -q "802\.3") ] || break