ID: 50 - ipmi_hpmfwupg needs a clean up

HpmfwupgQuerySelftestResult() - kill one level of indentation.
This commit is contained in:
Zdenek Styblik 2013-10-11 04:14:59 +00:00
parent f19ed0a90b
commit 60a3e63429

View File

@ -2233,26 +2233,25 @@ HpmfwupgQuerySelftestResult(struct ipmi_intf *intf, struct HpmfwupgQuerySelftest
} while (rsp
&& (rsp->ccode == HPMFWUPG_COMMAND_IN_PROGRESS)
&& (timeoutSec2 - timeoutSec1 < selfTestTimeout));
if (rsp) {
if (rsp->ccode == 0x00) {
memcpy(&pCtx->resp, rsp->data,
sizeof(struct HpmfwupgQuerySelftestResultResp));
if (verbose) {
lprintf(LOG_NOTICE, "Self test results:");
lprintf(LOG_NOTICE, "Result1 = %x",
pCtx->resp.result1);
lprintf(LOG_NOTICE, "Result2 = %x",
pCtx->resp.result2);
}
} else {
lprintf(LOG_NOTICE, "Error getting self test results");
lprintf(LOG_NOTICE, "compcode=0x%x: %s",
rsp->ccode,
val2str(rsp->ccode, completion_code_vals));
rc = HPMFWUPG_ERROR;
if (rsp == NULL) {
lprintf(LOG_NOTICE, "Error getting upgrade status\n");
return HPMFWUPG_ERROR;
}
if (rsp->ccode == 0x00) {
memcpy(&pCtx->resp, rsp->data,
sizeof(struct HpmfwupgQuerySelftestResultResp));
if (verbose) {
lprintf(LOG_NOTICE, "Self test results:");
lprintf(LOG_NOTICE, "Result1 = %x",
pCtx->resp.result1);
lprintf(LOG_NOTICE, "Result2 = %x",
pCtx->resp.result2);
}
} else {
lprintf(LOG_NOTICE, "Error getting upgrade status\n");
lprintf(LOG_NOTICE, "Error getting self test results");
lprintf(LOG_NOTICE, "compcode=0x%x: %s",
rsp->ccode,
val2str(rsp->ccode, completion_code_vals));
rc = HPMFWUPG_ERROR;
}
return rc;