deepblue/ipmitool
1
0
Fork 0
mirror of https://github.com/ipmitool/ipmitool.git synced 2025-05-10 18:47:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix sequence number issues, and abort (for debugging) on error

Browse Source
This commit is contained in:
Jeremy Ellington 2004-07-20 16:07:12 +00:00
parent a3295bba5e
commit 6801a7300c
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
ipmitool/src/plugins/lanplus/lanplus.c
View File

@ -511,7 +511,8 @@ ipmi_lan_poll_recv(struct ipmi_intf * intf)
{ {
printf("ERROR: Received message with invalid authcode!\n"); printf("ERROR: Received message with invalid authcode!\n");
rsp = ipmi_lan_recv_packet(intf); rsp = ipmi_lan_recv_packet(intf);
continue; assert(0);
//continue;
} }
@ -1897,6 +1898,10 @@ int ipmi_lanplus_send_sol(struct ipmi_intf * intf,
*/ */
v2_payload->payload.sol_packet.acked_packet_number = 0; /* NA */ v2_payload->payload.sol_packet.acked_packet_number = 0; /* NA */
/* Keep our sequence number sane */
if (intf->session->sol_data.sequence_number > 0x0F)
intf->session->sol_data.sequence_number = 1;
v2_payload->payload.sol_packet.packet_sequence_number = v2_payload->payload.sol_packet.packet_sequence_number =
intf->session->sol_data.sequence_number++; intf->session->sol_data.sequence_number++;
@ -1921,7 +1926,7 @@ struct ipmi_rs * ipmi_lanplus_recv_sol(struct ipmi_intf * intf)
struct ipmi_rs * rsp = ipmi_lan_poll_recv(intf); struct ipmi_rs * rsp = ipmi_lan_poll_recv(intf);
/* If the SOL packet looks good, ACK it */ /* If the SOL packet looks good, ACK it */
if (rsp && (rsp->data_len > 4)) if (rsp && rsp->data_len)
{ {
bzero(&ack, sizeof(struct ipmi_v2_payload)); bzero(&ack, sizeof(struct ipmi_v2_payload));
@ -1933,8 +1938,8 @@ struct ipmi_rs * ipmi_lanplus_recv_sol(struct ipmi_intf * intf)
*/ */
ack.payload_length = 0; ack.payload_length = 0;
ack.payload.sol_packet.packet_sequence_number = /* ACK packets have sequence numbers of 0 */
intf->session->sol_data.sequence_number++; ack.payload.sol_packet.packet_sequence_number = 0;
ack.payload.sol_packet.acked_packet_number = ack.payload.sol_packet.acked_packet_number =
rsp->payload.sol_packet.packet_sequence_number; rsp->payload.sol_packet.packet_sequence_number;