deepblue/ipmitool
1
0
Fork 0
mirror of https://github.com/ipmitool/ipmitool.git synced 2025-05-10 18:47:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

3600946 check for failed bind on send, leaks

Browse Source
This commit is contained in:
Ales Ledvinka 2013-01-16 12:20:52 +00:00
parent 6a82e95988
commit 6eda3b5482
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
ipmitool/lib/ipmi_tsol.c
View File

@ -446,7 +446,10 @@ ipmi_tsol_main(struct ipmi_intf * intf, int argc, char ** argv)
lprintf(LOG_ERR, "Can't open port %d", port); lprintf(LOG_ERR, "Can't open port %d", port);
return -1; return -1;
} }
bind(fd_socket, (struct sockaddr *)&sin, sizeof(sin)); if (-1 == bind(fd_socket, (struct sockaddr *)&sin, sizeof(sin))) {
lprintf(LOG_ERR, "Failed to bind socket.");
return -1;
}
/* /*
* retrieve local IP address if not supplied on command line * retrieve local IP address if not supplied on command line
@ -454,17 +457,20 @@ ipmi_tsol_main(struct ipmi_intf * intf, int argc, char ** argv)
if (recvip == NULL) { if (recvip == NULL) {
result = intf->open(intf); /* must connect first */ result = intf->open(intf); /* must connect first */
if (result < 0) if (result < 0)
close(fd_socket);
return -1; return -1;
mylen = sizeof(myaddr); mylen = sizeof(myaddr);
if (getsockname(intf->fd, (struct sockaddr *)&myaddr, &mylen) < 0) { if (getsockname(intf->fd, (struct sockaddr *)&myaddr, &mylen) < 0) {
lperror(LOG_ERR, "getsockname failed"); lperror(LOG_ERR, "getsockname failed");
close(fd_socket);
return -1; return -1;
} }
recvip = inet_ntoa(myaddr.sin_addr); recvip = inet_ntoa(myaddr.sin_addr);
if (recvip == NULL) { if (recvip == NULL) {
lprintf(LOG_ERR, "Unable to find local IP address"); lprintf(LOG_ERR, "Unable to find local IP address");
close(fd_socket);
return -1; return -1;
} }
} }
@ -482,6 +488,7 @@ ipmi_tsol_main(struct ipmi_intf * intf, int argc, char ** argv)
result = ipmi_tsol_start(intf, recvip, port); result = ipmi_tsol_start(intf, recvip, port);
if (result < 0) { if (result < 0) {
lprintf(LOG_ERR, "Error starting SOL"); lprintf(LOG_ERR, "Error starting SOL");
close(fd_socket);
return -1; return -1;
} }