From 72d66edc6c076ad1c9107b3ead5d2085fb305949 Mon Sep 17 00:00:00 2001 From: Francois Isabelle Date: Fri, 5 Jun 2009 15:02:39 +0000 Subject: [PATCH] Bug fix:Some sensor will wrongfully report '0' as interpreted reading - Avoid treating '0' raw value as a special case. --- ipmitool/lib/ipmi_sdr.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/ipmitool/lib/ipmi_sdr.c b/ipmitool/lib/ipmi_sdr.c index e06a4bd..826a34c 100644 --- a/ipmitool/lib/ipmi_sdr.c +++ b/ipmitool/lib/ipmi_sdr.c @@ -1180,7 +1180,7 @@ ipmi_sdr_print_sensor_full(struct ipmi_intf *intf, if (val != 0.0) validread = 1; } - } else if (rsp->data[0] != 0) { + } else { /* Non linear sensors might provide updated reading factors */ if (sensor->linearization>=SDR_SENSOR_L_NONLINEAR && sensor->linearization<=0x7F) { if (ipmi_sensor_get_sensor_reading_factors(intf, sensor, rsp->data[0]) < 0){ @@ -1188,9 +1188,7 @@ ipmi_sdr_print_sensor_full(struct ipmi_intf *intf, } } /* convert RAW reading into units */ - if (rsp->data[0] != 0) { val = sdr_convert_sensor_reading(sensor, rsp->data[0]); - } } }