From 738cf02694b0ee5d7a458e3eb8e97deb3a7a20fa Mon Sep 17 00:00:00 2001 From: Jean-Michel Audet Date: Fri, 28 Oct 2005 14:10:48 +0000 Subject: [PATCH] On all IPMI commands, the structure ipmi_rq must be cleared (memset(&req, 0, sizeof(req)). This was not done for the 4 commands sent. This was causing some commands sent to the KCS interface to have an invalid LUN. --- ipmitool/lib/ipmi_sol.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/ipmitool/lib/ipmi_sol.c b/ipmitool/lib/ipmi_sol.c index 0c08070..3bbe6e8 100644 --- a/ipmitool/lib/ipmi_sol.c +++ b/ipmitool/lib/ipmi_sol.c @@ -102,6 +102,7 @@ ipmi_get_sol_info( struct ipmi_rq req; uint8_t data[4]; + memset(&req, 0, sizeof(req)); req.msg.netfn = IPMI_NETFN_TRANSPORT; req.msg.cmd = IMPI_GET_SOL_CONFIG_PARAMETERS; req.msg.data_len = 4; @@ -547,6 +548,7 @@ ipmi_sol_set_param(struct ipmi_intf * intf, uint8_t data[4]; int bGuarded = 1; /* Use set-in-progress indicator? */ + memset(&req, 0, sizeof(req)); req.msg.netfn = IPMI_NETFN_TRANSPORT; /* 0x0c */ req.msg.cmd = IMPI_SET_SOL_CONFIG_PARAMETERS; /* 0x21 */ req.msg.data = data; @@ -1100,6 +1102,7 @@ ipmi_sol_deactivate(struct ipmi_intf * intf) struct ipmi_rq req; uint8_t data[6]; + memset(&req, 0, sizeof(req)); req.msg.netfn = IPMI_NETFN_APP; req.msg.cmd = IPMI_DEACTIVATE_PAYLOAD; req.msg.data_len = 6; @@ -1410,6 +1413,7 @@ ipmi_sol_activate(struct ipmi_intf * intf) intf->session->sol_data.sol_input_handler = output; + memset(&req, 0, sizeof(req)); req.msg.netfn = IPMI_NETFN_APP; req.msg.cmd = IPMI_ACTIVATE_PAYLOAD; req.msg.data_len = 6;