deepblue/ipmitool
1
0
Fork 0
mirror of https://github.com/ipmitool/ipmitool.git synced 2025-05-10 18:47:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

ID:412 - Check errors when setting a user password.

Browse Source 
An error which can happen when setting a user password is silently ignored.
Add a completion code check and report error if any.
This commit is contained in:
Alexander Yurtsev 2015-11-16 13:40:16 +03:00 committed by Zdenek Styblik
parent f67a7a3b2f
commit 8055e0d9fb
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
lib/ipmi_user.c
View File

@ -602,6 +602,7 @@ ipmi_user_mod(struct ipmi_intf *intf, int argc, char **argv)
/* Disable / Enable */ /* Disable / Enable */
uint8_t user_id; uint8_t user_id;
uint8_t operation; uint8_t operation;
uint8_t ccode;
if (argc != 2) { if (argc != 2) {
print_user_usage(); print_user_usage();
@ -613,8 +614,14 @@ ipmi_user_mod(struct ipmi_intf *intf, int argc, char **argv)
operation = (strncmp(argv[0], "disable", 7) == 0) ? operation = (strncmp(argv[0], "disable", 7) == 0) ?
IPMI_PASSWORD_DISABLE_USER : IPMI_PASSWORD_ENABLE_USER; IPMI_PASSWORD_DISABLE_USER : IPMI_PASSWORD_ENABLE_USER;
return _ipmi_set_user_password(intf, user_id, operation, ccode = _ipmi_set_user_password(intf, user_id, operation,
(char *)NULL, 0); (char *)NULL, 0);
if (eval_ccode(ccode) != 0) {
lprintf(LOG_ERR, "Set User Password command failed (user %d)",
user_id);
return (-1);
}
return 0;
} }
int int