deepblue/ipmitool
1
0
Fork 0
mirror of https://github.com/ipmitool/ipmitool.git synced 2025-05-10 18:47:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

ID: 50 - ipmi_hpmfwupg needs a clean up

Browse Source 
HpmfwupgActivateFirmware(), HpmfwupgGetUpgradeStatus() - kill one level of
indentation.
This commit is contained in:
Zdenek Styblik 2013-10-10 11:49:53 +00:00
parent 6de0796079
commit 80c03570ac
1 changed files with 34 additions and 36 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
ipmitool/lib/ipmi_hpmfwupg.c
View File

@ -1944,7 +1944,10 @@ HpmfwupgFinishFirmwareUpload(struct ipmi_intf *intf,
req.msg.data = (unsigned char*)&pCtx->req; req.msg.data = (unsigned char*)&pCtx->req;
req.msg.data_len = sizeof(struct HpmfwupgFinishFirmwareUploadReq); req.msg.data_len = sizeof(struct HpmfwupgFinishFirmwareUploadReq);
rsp = HpmfwupgSendCmd(intf, req, pFwupgCtx); rsp = HpmfwupgSendCmd(intf, req, pFwupgCtx);
if (rsp) { if (rsp == NULL) {
lprintf(LOG_ERR, "Error fininshing firmware upload.");
return HPMFWUPG_ERROR;
}
/* Long duration command handling */ /* Long duration command handling */
if (rsp->ccode == HPMFWUPG_COMMAND_IN_PROGRESS) { if (rsp->ccode == HPMFWUPG_COMMAND_IN_PROGRESS) {
rc = HpmfwupgWaitLongDurationCmd(intf, pFwupgCtx); rc = HpmfwupgWaitLongDurationCmd(intf, pFwupgCtx);
@ -1953,16 +1956,12 @@ HpmfwupgFinishFirmwareUpload(struct ipmi_intf *intf,
} else if ((option & COMPARE_MODE) && rsp->ccode == IPMI_CC_OK) { } else if ((option & COMPARE_MODE) && rsp->ccode == IPMI_CC_OK) {
printf("| |Comparison passed |\n"); printf("| |Comparison passed |\n");
} else if ( rsp->ccode != IPMI_CC_OK ) { } else if ( rsp->ccode != IPMI_CC_OK ) {
lprintf(LOG_NOTICE,"Error finishing firmware upload"); lprintf(LOG_ERR, "Error finishing firmware upload");
lprintf(LOG_NOTICE,"compcode=0x%x: %s", lprintf(LOG_ERR, "compcode=0x%x: %s",
rsp->ccode, rsp->ccode,
val2str(rsp->ccode, completion_code_vals)); val2str(rsp->ccode, completion_code_vals));
rc = HPMFWUPG_ERROR; rc = HPMFWUPG_ERROR;
} }
} else {
lprintf(LOG_NOTICE,"Error fininshing firmware upload\n");
rc = HPMFWUPG_ERROR;
}
return rc; return rc;
} }
@ -1982,7 +1981,10 @@ HpmfwupgActivateFirmware(struct ipmi_intf *intf,
req.msg.data_len = sizeof(struct HpmfwupgActivateFirmwareReq) req.msg.data_len = sizeof(struct HpmfwupgActivateFirmwareReq)
- (!pCtx->req.rollback_override ? 1 : 0); - (!pCtx->req.rollback_override ? 1 : 0);
rsp = HpmfwupgSendCmd(intf, req, pFwupgCtx); rsp = HpmfwupgSendCmd(intf, req, pFwupgCtx);
if (rsp) { if (rsp == NULL) {
lprintf(LOG_ERR, "Error activating firmware.");
return HPMFWUPG_ERROR;
}
/* Long duration command handling */ /* Long duration command handling */
if (rsp->ccode == HPMFWUPG_COMMAND_IN_PROGRESS) { if (rsp->ccode == HPMFWUPG_COMMAND_IN_PROGRESS) {
printf("Waiting firmware activation..."); printf("Waiting firmware activation...");
@ -1994,16 +1996,12 @@ HpmfwupgActivateFirmware(struct ipmi_intf *intf,
lprintf(LOG_NOTICE, "Failed"); lprintf(LOG_NOTICE, "Failed");
} }
} else if (rsp->ccode != IPMI_CC_OK) { } else if (rsp->ccode != IPMI_CC_OK) {
lprintf(LOG_NOTICE, "Error activating firmware"); lprintf(LOG_ERR, "Error activating firmware");
lprintf(LOG_NOTICE, "compcode=0x%x: %s", lprintf(LOG_ERR, "compcode=0x%x: %s",
rsp->ccode, rsp->ccode,
val2str(rsp->ccode, completion_code_vals)); val2str(rsp->ccode, completion_code_vals));
rc = HPMFWUPG_ERROR; rc = HPMFWUPG_ERROR;
} }
} else {
lprintf(LOG_NOTICE, "Error activating firmware\n");
rc = HPMFWUPG_ERROR;
}
return rc; return rc;
} }