fru: change ipmi_fru_query_new_value to return bool

Change ipmi_fru_query_new_value to return the bool type
instead of an int that's being used as a boolean value.

Signed-off-by: Patrick Venture <venture@google.com>
This commit is contained in:
Patrick Venture 2018-12-04 09:52:54 -08:00 committed by Alexander Amelkin
parent 49384e47be
commit 8991f5a9a0

View File

@ -1487,17 +1487,17 @@ fru_area_print_multirec(struct ipmi_intf * intf, struct fru_info * fru,
* returns : FALSE if data not changed * returns : FALSE if data not changed
*/ */
static static
int bool
ipmi_fru_query_new_value(uint8_t *data,int offset, size_t len) ipmi_fru_query_new_value(uint8_t *data,int offset, size_t len)
{ {
int status=FALSE; bool status = false;
int ret; int ret;
char answer; char answer;
printf("Would you like to change this value <y/n> ? "); printf("Would you like to change this value <y/n> ? ");
ret = scanf("%c", &answer); ret = scanf("%c", &answer);
if (ret != 1) { if (ret != 1) {
return FALSE; return false;
} }
if( answer == 'y' || answer == 'Y' ){ if( answer == 'y' || answer == 'Y' ){
@ -1514,7 +1514,7 @@ ipmi_fru_query_new_value(uint8_t *data,int offset, size_t len)
ret = scanf("%x", holder+i); ret = scanf("%x", holder+i);
if (ret != 1) { if (ret != 1) {
free(holder); free(holder);
return FALSE; return false;
} }
} }
for( i=0;i<len;i++ ){ for( i=0;i<len;i++ ){
@ -1523,7 +1523,7 @@ ipmi_fru_query_new_value(uint8_t *data,int offset, size_t len)
/* &data[offset++] */ /* &data[offset++] */
free(holder); free(holder);
holder = NULL; holder = NULL;
status = TRUE; status = true;
} }
else{ else{
printf("Entered %c\n",answer); printf("Entered %c\n",answer);