deepblue/ipmitool
1
0
Fork 0
mirror of https://github.com/ipmitool/ipmitool.git synced 2025-05-11 11:07:23 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

ID: 46 - ipmi_fwum needs some re-work

Browse Source 
ipmi_fwum_main() re-work.
This commit is contained in:
Zdenek Styblik 2013-10-26 17:10:14 +00:00
parent ae96dd3229
commit 9517cb332b
1 changed files with 53 additions and 73 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

88
ipmitool/lib/ipmi_fwum.c
View File

@ -197,79 +197,59 @@ static void KfwumOutputInfo(tKFWUM_BoardInfo boardInfo,
*/ */
int ipmi_fwum_main(struct ipmi_intf * intf, int argc, char ** argv) int ipmi_fwum_main(struct ipmi_intf * intf, int argc, char ** argv)
{ {
int rc = 0;
printf("FWUM extension Version %d.%d\n", VERSION_MAJ, VERSION_MIN); printf("FWUM extension Version %d.%d\n", VERSION_MAJ, VERSION_MIN);
if ((!argc) || ( !strncmp(argv[0], "help", 4))) if (argc < 1) {
{ lprintf(LOG_ERR, "Not enough parameters given.");
KfwumOutputHelp(); KfwumOutputHelp();
return (-1);
} }
else if (strncmp(argv[0], "help", 4) == 0) {
{ KfwumOutputHelp();
if (!strncmp(argv[0], "info", 4)) rc = 0;
{ } else if (strncmp(argv[0], "info", 4) == 0) {
KfwumMain(intf, KFWUM_TASK_INFO); KfwumMain(intf, KFWUM_TASK_INFO);
} } else if (strncmp(argv[0], "status", 6) == 0) {
else if (!strncmp(argv[0], "status", 6))
{
KfwumMain(intf, KFWUM_TASK_STATUS); KfwumMain(intf, KFWUM_TASK_STATUS);
} } else if (strncmp(argv[0], "rollback", 8) == 0) {
else if (!strncmp(argv[0], "rollback", 8))
{
KfwumMain(intf, KFWUM_TASK_ROLLBACK); KfwumMain(intf, KFWUM_TASK_ROLLBACK);
} else if (strncmp(argv[0], "download", 8) == 0) {
if ((argc < 2) || (strlen(argv[1]) < 1)) {
lprintf(LOG_ERR,
"Path and file name must be specified.");
return (-1);
} }
else if (!strncmp(argv[0], "download", 8))
{
if((argc >= 2) && (strlen(argv[1]) > 0))
{
/* There is a file name in the parameters */ /* There is a file name in the parameters */
if(strlen(argv[1]) < 512) if (strlen(argv[1]) >= 512) {
{ lprintf(LOG_ERR,
"File name length is limited to 512 characters.");
return (-1);
}
strcpy((char *)fileName, argv[1]); strcpy((char *)fileName, argv[1]);
printf("Firmware File Name : %s\n", fileName); printf("Firmware File Name : %s\n", fileName);
KfwumMain(intf, KFWUM_TASK_DOWNLOAD); KfwumMain(intf, KFWUM_TASK_DOWNLOAD);
} } else if (strncmp(argv[0], "upgrade", 7) == 0) {
else if ((argc >= 2) && (strlen(argv[1]) > 0)) {
{
fprintf(stderr,"File name must be smaller than 512 bytes\n");
}
}
else
{
fprintf(stderr,"A path and a file name must be specified\n");
}
}
else if (!strncmp(argv[0], "upgrade", 7))
{
if((argc >= 2) && (strlen(argv[1]) > 0))
{
/* There is a file name in the parameters */ /* There is a file name in the parameters */
if(strlen(argv[1]) < 512) if (strlen(argv[1]) >= 512) {
{ lprintf(LOG_ERR,
"File name length is limited to 512 characters.");
return (-1);
}
strcpy((char *)fileName, argv[1]); strcpy((char *)fileName, argv[1]);
printf("Upgrading using file name %s\n", fileName); printf("Upgrading using file name %s\n", fileName);
KfwumMain(intf, KFWUM_TASK_UPGRADE); KfwumMain(intf, KFWUM_TASK_UPGRADE);
} } else {
else
{
fprintf(stderr,"File name must be smaller than 512 bytes\n");
}
}
else
{
KfwumMain(intf, KFWUM_TASK_START_UPGRADE); KfwumMain(intf, KFWUM_TASK_START_UPGRADE);
} }
} else if (strncmp(argv[0], "tracelog", 8) == 0) {
}
else if (!strncmp(argv[0], "tracelog", 8))
{
KfwumMain(intf, KFWUM_TASK_TRACELOG); KfwumMain(intf, KFWUM_TASK_TRACELOG);
} else {
lprintf(LOG_ERR, "Invalid KFWUM command: %s", argv[0]);
KfwumOutputHelp();
rc = (-1);
} }
else return rc;
{
printf("Invalid KFWUM command: %s\n", argv[0]);
}
}
return 0;
} }