From 99e4ac0399c0c6895a9787926f7f525522cca4ff Mon Sep 17 00:00:00 2001 From: Zdenek Styblik Date: Wed, 5 Dec 2012 10:39:46 +0000 Subject: [PATCH] ID: 3592770 - # ipmitool sdr list|elist INV_INPUT; return code Commit fixes return code of # ipmitool sdr list|elist; when invalid input/unknown command is given. Return code is > 0 now and error message is printed. --- ipmitool/lib/ipmi_sdr.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/ipmitool/lib/ipmi_sdr.c b/ipmitool/lib/ipmi_sdr.c index ebbfd84..c5686bd 100644 --- a/ipmitool/lib/ipmi_sdr.c +++ b/ipmitool/lib/ipmi_sdr.c @@ -4558,9 +4558,13 @@ ipmi_sdr_main(struct ipmi_intf *intf, int argc, char **argv) else if (strncmp(argv[1], "generic", 7) == 0) rc = ipmi_sdr_print_sdr(intf, SDR_RECORD_TYPE_GENERIC_DEVICE_LOCATOR); - else - lprintf(LOG_ERR, - "usage: sdr list [all|full|compact|event|mcloc|fru|generic]"); + else { + lprintf(LOG_ERR, "Invalid SDR %s command: %s", argv[0], argv[1]); + lprintf(LOG_NOTICE, + "usage: sdr %s [all|full|compact|event|mcloc|fru|generic]", + argv[0]); + return (-1); + } } else if (strncmp(argv[0], "type", 4) == 0) { sdr_extended = 1; rc = ipmi_sdr_print_type(intf, argv[1]);