deepblue/ipmitool
1
0
Fork 0
mirror of https://github.com/ipmitool/ipmitool.git synced 2025-05-10 18:47:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Make sure blockId buffer is never overflown (Coverity CID 1149058).

Browse Source
This commit is contained in:
Petter Reinholdtsen 2014-01-11 07:22:46 +00:00
parent df3e3c7969
commit 99fff91f9d
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ipmitool/lib/ipmi_fru.c
View File

@ -311,7 +311,10 @@ build_fru_bloc(struct ipmi_intf * intf, struct fru_info *fru, uint8_t id)
p_new->next = NULL; p_new->next = NULL;
p_new->start = header.offsets[i] * 8; p_new->start = header.offsets[i] * 8;
p_new->size = fru->size - p_new->start; p_new->size = fru->size - p_new->start;
strcpy((char *)p_new->blocId, section_id[i]);
strncpy((char *)p_new->blocId, section_id[i], sizeof(p_new->blocId));
/* Make sure string is null terminated */
p_new->blocId[sizeof(p_new->blocId)-1] = 0;
p_bloc->next = p_new; p_bloc->next = p_new;
p_bloc->size = p_new->start - p_bloc->start; p_bloc->size = p_new->start - p_bloc->start;