From 9a861894255df2f2f8682b619d2ecb1ccb5c8591 Mon Sep 17 00:00:00 2001 From: Bing-Hua Wang Date: Thu, 12 Nov 2020 17:57:50 +0800 Subject: [PATCH] free: Fix implicit function declarations GitHub Actions macOS environment now has Xcode 12.0.1. [1] Xcode 12 Clang enables -Werror=implicit-function-declaration by default [2] and breaks the ipmitool build on macOS. [3] [1] https://github.com/actions/virtual-environments/issues/1712 [2] https://developer.apple.com/documentation/xcode-release-notes/xcode-12-release-notes "Clang now reports an error when you use a function without an explicit declaration when building C or Objective-C code for macOS (-Werror=implicit-function-declaration flag is on)." [3] https://github.com/ipmitool/ipmitool/pull/252/checks?check_run_id=1389463134 "checking for ld used by gcc... /Applications/Xcode_12.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ld free.c:66:13: error: implicit declaration of function 'getuid' is invalid in C99 [-Werror,-Wimplicit-function-declaration] if (getuid() != 0) { ^ free.c:170:26: error: implicit declaration of function 'ipmi_get_oem' is invalid in C99 [-Werror,-Wimplicit-function-declaration] intf->manufacturer_id = ipmi_get_oem(intf);" ^ Signed-off-by: Bing-Hua Wang --- src/plugins/free/free.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/plugins/free/free.c b/src/plugins/free/free.c index 56c8157..96fc9ad 100644 --- a/src/plugins/free/free.c +++ b/src/plugins/free/free.c @@ -42,9 +42,11 @@ #include #include #include +#include #include #include +#include #include #if IPMI_INTF_FREE_0_3_0 || IPMI_INTF_FREE_0_4_0 || IPMI_INTF_FREE_0_5_0