deepblue/ipmitool
1
0
Fork 0
mirror of https://github.com/ipmitool/ipmitool.git synced 2025-05-10 10:37:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

ID:355 - Fix zero-length format string warning in get_supermicro_evt_desc()

Browse Source
This commit is contained in:
Zdenek Styblik 2015-01-22 06:20:55 +01:00
parent 82a0caa38b
commit aabd9eb1ac
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/ipmi_sel.c
View File

@ -556,12 +556,12 @@ get_supermicro_evt_desc(struct ipmi_intf *intf, struct sel_event_record *rec)
return NULL; return NULL;
} }
/* Allocate mem for te Description string */ /* Allocate mem for te Description string */
desc = (char *)malloc(SIZE_OF_DESC); desc = malloc(sizeof(char) * SIZE_OF_DESC);
if (desc == NULL) { if (desc == NULL) {
lprintf(LOG_ERR, "ipmitool: malloc failure"); lprintf(LOG_ERR, "ipmitool: malloc failure");
return NULL; return NULL;
} }
memset(desc,0,SIZE_OF_DESC); memset(desc, '\0', SIZE_OF_DESC);
sensor_type = rec->sel_type.standard_type.sensor_type; sensor_type = rec->sel_type.standard_type.sensor_type;
switch (sensor_type) { switch (sensor_type) {
case SENSOR_TYPE_MEMORY: case SENSOR_TYPE_MEMORY:
@ -623,7 +623,8 @@ get_supermicro_evt_desc(struct ipmi_intf *intf, struct sel_event_record *rec)
(data2 >> 4) + 0x40 + (data3 & 0x3) * 3, (data2 >> 4) + 0x40 + (data3 & 0x3) * 3,
(data2 & 0xf) + 0x27, (data3 & 0x03) + 1); (data2 & 0xf) + 0x27, (data3 & 0x03) + 1);
} else { } else {
snprintf(desc, SIZE_OF_DESC, ""); /* No description. */
desc[0] = '\0';
} }
break; break;
case SENSOR_TYPE_SUPERMICRO_OEM: case SENSOR_TYPE_SUPERMICRO_OEM: