deepblue/ipmitool
1
0
Fork 0
mirror of https://github.com/ipmitool/ipmitool.git synced 2025-05-10 18:47:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

ID:349 - user set password - add option to choose 16/20 byte password

Browse Source 
Commit adds option to 'user set password' to choose whether password should be
stored as 16 byte or 20 byte. From now on, it's possible to store even 5 bytes
long password as 20 byte password which should make it useless for IPMI v1.5
auth/sessions.
This commit is contained in:
Zdenek Styblik 2014-12-20 16:40:55 +01:00
parent 6e6a04f971
commit ad77da2065
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
lib/ipmi_user.c
View File

@ -496,7 +496,7 @@ print_user_usage(void)
lprintf(LOG_NOTICE, lprintf(LOG_NOTICE,
" set name <user id> <username>"); " set name <user id> <username>");
lprintf(LOG_NOTICE, lprintf(LOG_NOTICE,
" set password <user id> [<password>]"); " set password <user id> [<password> <16|20>]");
lprintf(LOG_NOTICE, lprintf(LOG_NOTICE,
" disable <user id>"); " disable <user id>");
lprintf(LOG_NOTICE, lprintf(LOG_NOTICE,
@ -685,6 +685,7 @@ int
ipmi_user_password(struct ipmi_intf *intf, int argc, char **argv) ipmi_user_password(struct ipmi_intf *intf, int argc, char **argv)
{ {
char *password = NULL; char *password = NULL;
uint8_t password_type = 16;
uint8_t user_id = 0; uint8_t user_id = 0;
if (is_ipmi_user_id(argv[2], &user_id)) { if (is_ipmi_user_id(argv[2], &user_id)) {
return (-1); return (-1);
@ -710,6 +711,15 @@ ipmi_user_password(struct ipmi_intf *intf, int argc, char **argv)
} }
} else { } else {
password = argv[3]; password = argv[3];
if (argc > 4) {
if ((str2uchar(argv[4], &password_type) != 0)
|| (password_type != 16 && password_type != 20)) {
lprintf(LOG_ERR, "Invalid password length '%s'", argv[4]);
return (-1);
}
} else {
password_type = 16;
}
} }
if (password == NULL) { if (password == NULL) {
@ -724,7 +734,7 @@ ipmi_user_password(struct ipmi_intf *intf, int argc, char **argv)
user_id, user_id,
IPMI_PASSWORD_SET_PASSWORD, IPMI_PASSWORD_SET_PASSWORD,
password, password,
strlen(password) > 16); password_type > 16);
} }
int int