From c2e65d0dce7cccad5c482ac37eb7f606850c79d3 Mon Sep 17 00:00:00 2001 From: Zdenek Styblik Date: Tue, 30 Dec 2014 17:40:07 +0100 Subject: [PATCH] Fix dead code in ipmi_firewall_reset() - CID#1261342 --- lib/ipmi_firewall.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/ipmi_firewall.c b/lib/ipmi_firewall.c index 8bda398..2803bc0 100644 --- a/lib/ipmi_firewall.c +++ b/lib/ipmi_firewall.c @@ -1110,7 +1110,11 @@ ipmi_firewall_reset(struct ipmi_intf * intf, int argc, char ** argv) unsigned int l, n, c, ret; unsigned char enables[MAX_COMMAND_BYTES]; - if (argc > 0 || (argc > 0 && strncmp(argv[0], "help", 4) == 0)) { + if (argc < 1) { + lprintf(LOG_ERR, "Not enough parameters given."); + printf_firewall_usage(); + return (-1); + } else if (argc > 0 && strncmp(argv[0], "help", 4) == 0) { printf_firewall_usage(); return 0; }