From c62359bd798fa17b7f8a3228dd55d31d22ac9cfe Mon Sep 17 00:00:00 2001 From: Zdenek Styblik Date: Thu, 4 Oct 2012 07:46:27 +0000 Subject: [PATCH] lib/ipmi_fru.c - pointless/wrong cast loop Commit removes pointless(?) and unhandled cast from uint32_t to uint8_t and back. intf->target_addr is uint32_t, don't try to "squeeze" it into uint8_t then. --- ipmitool/lib/ipmi_fru.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ipmitool/lib/ipmi_fru.c b/ipmitool/lib/ipmi_fru.c index 59a6a55..9a26f77 100644 --- a/ipmitool/lib/ipmi_fru.c +++ b/ipmitool/lib/ipmi_fru.c @@ -2839,7 +2839,7 @@ int ipmi_fru_print(struct ipmi_intf * intf, struct sdr_record_fru_locator * fru) { char desc[17]; - uint8_t save_addr; + uint32_t save_addr; int rc = 0; if (fru == NULL) @@ -2922,7 +2922,7 @@ ipmi_fru_print_all(struct ipmi_intf * intf) struct ipmi_rq req; struct ipm_devid_rsp *devid; struct sdr_record_mc_locator * mc; - uint8_t save_addr; + uint32_t save_addr; printf("FRU Device Description : Builtin FRU Device (ID 0)\n"); /* TODO: Figure out if FRU device 0 may show up in SDR records. */