deepblue/ipmitool
1
0
Fork 0
mirror of https://github.com/ipmitool/ipmitool.git synced 2025-05-10 18:47:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix default interface to behave as it did before

Browse Source 
Prior to 95038ba01b99153de870dde91406bdc1c7265217 the default interface
was 'open' for builds where it was available and 'lan' otherwise. Due to
a logic error in 95038ba01b99153de870dde91406bdc1c7265217, the default
interface was always getting set to lan unless it was specified by the
environment variable. This commit fixes the logic and sets the default
to open if it is available and lan otherwise.

Resolves ipmitool/ipmitool#128

Tested: ./configure # no options reports 'open' as default
        ./configure --enable-intf-open=no # reports lan as default
        ./configure --enable-intf-dbus DEFAULT_INTF=dbus # reports dbus

Signed-off-by: Vernon Mauery <vernon.mauery@intel.com>
This commit is contained in:
Vernon Mauery 2019-06-06 09:31:18 -07:00 committed by Alexander Amelkin
parent a45704e5ea
commit ca7767793e
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
configure.ac
View File

@ -672,13 +672,13 @@ AC_TRY_COMPILE([],[
) )
dnl if no environment variable is set, set the default value for the default intf dnl if no environment variable is set, set the default value for the default intf
if test "${xenable_intf_open}" = "xyes"; then if test "${xenable_intf_open}" = "yes"; then
DEFAULT_INTF_NO_ENV=open DEFAULT_INTF_NO_ENV=open
else dnl macOS does not build open interface, it defaults to lan else dnl macOS does not build open interface, it defaults to lan
DEFAULT_INTF_NO_ENV=lan DEFAULT_INTF_NO_ENV=lan
fi fi
dnl allow for a default interface to be set on configure dnl allow for a default interface to be set on configure
AC_ARG_VAR(DEFAULT_INTF, [Set the default interface to use (default=${DEFAULT_INTF_NO_ENV})]) AC_ARG_VAR(DEFAULT_INTF, [Set the default interface to use (default='open' if available, 'lan' otherwise)])
dnl set the default value for the default interface environment variable dnl set the default value for the default interface environment variable
if test "x${DEFAULT_INTF}" == "x"; then if test "x${DEFAULT_INTF}" == "x"; then