deepblue/ipmitool
1
0
Fork 0
mirror of https://github.com/ipmitool/ipmitool.git synced 2026-06-29 16:51:35 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Refactoring: optimize pointer checks

Browse Source 
Remove all direct comparisons to 'NULL' for pointers.
Replace them with boolean-like 'if (ptr)' and 'if (!ptr)'.
This makes conditions shorter and easier to read.

Signed-off-by: Alexander Amelkin <alexander@amelkin.msk.ru>
This commit is contained in:
Alexander Amelkin
2018-08-21 17:16:19 +03:00
parent f3ef88724f
commit e9716e216d
48 changed files with 1050 additions and 1090 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lib/ipmi_lanp6.c
View File

@@ -333,7 +333,7 @@ ipmi_lanp_err(const struct ipmi_rs *rsp, const struct ipmi_lanp *p,
int log_level = LOG_ERR;
int err;
if (rsp == NULL) {
if (!rsp) {
reason = "No response";
err = -1;
} else {
@@ -354,7 +354,7 @@ ipmi_lanp_err(const struct ipmi_rs *rsp, const struct ipmi_lanp *p,
reason = val2str(rsp->ccode, lanp_cc_vals);
}
if (reason == NULL) {
if (!reason) {
/* print completion code value */
snprintf(cc_msg, sizeof(cc_msg), "CC=%02x", rsp->ccode);
reason = cc_msg;
@@ -403,7 +403,7 @@ ipmi_get_dynamic_oem_lanp(void *priv, const struct ipmi_lanp *param,
param->name, set_selector, block_selector);
rsp = lp->intf->sendrecv(lp->intf, &req);
if (rsp == NULL || rsp->ccode) {
if (!rsp || rsp->ccode) {
return ipmi_lanp_err(rsp, param, "get", quiet);
}
@@ -467,7 +467,7 @@ ipmi_set_dynamic_oem_lanp(void *priv, const struct ipmi_lanp *param,
lprintf(LOG_INFO, "Setting parameter '%s'", param->name);
rsp = lp->intf->sendrecv(lp->intf, &req);
if (rsp == NULL || rsp->ccode) {
if (!rsp || rsp->ccode) {
return ipmi_lanp_err(rsp, param, "set", 0);
}