deepblue/ipmitool
1
0
Fork 0
mirror of https://github.com/ipmitool/ipmitool.git synced 2025-05-10 18:47:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

ID:480 - ipmitool coredumps in EVP_CIPHER_CTX_init

Browse Source 
IPMI tool coredumps due to changes introduced in ID:461. This shouldn't be
surprise as a NULL pointer is passed to init. Commit addresses this issue by
calling EVP_CIPHER_CTX_new() instead of EVP_CIPHER_CTX_init(), which is
deprecated, and by checking return value of call to former function.
This commit is contained in:
Zdenek Styblik 2017-03-12 14:00:35 +01:00
parent ba01dc84b4
commit f004b4b719
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/plugins/lanplus/lanplus_crypt_impl.c
View File

@ -165,11 +165,14 @@ lanplus_encrypt_aes_cbc_128(const uint8_t * iv,
uint32_t * bytes_written) uint32_t * bytes_written)
{ {
EVP_CIPHER_CTX *ctx = NULL; EVP_CIPHER_CTX *ctx = NULL;
EVP_CIPHER_CTX_init(ctx); ctx = EVP_CIPHER_CTX_new();
if (ctx == NULL) {
*bytes_written = 0;
return;
}
EVP_EncryptInit_ex(ctx, EVP_aes_128_cbc(), NULL, key, iv); EVP_EncryptInit_ex(ctx, EVP_aes_128_cbc(), NULL, key, iv);
EVP_CIPHER_CTX_set_padding(ctx, 0); EVP_CIPHER_CTX_set_padding(ctx, 0);
*bytes_written = 0; *bytes_written = 0;
if (input_length == 0) if (input_length == 0)
@ -240,11 +243,14 @@ lanplus_decrypt_aes_cbc_128(const uint8_t * iv,
uint32_t * bytes_written) uint32_t * bytes_written)
{ {
EVP_CIPHER_CTX *ctx = NULL; EVP_CIPHER_CTX *ctx = NULL;
EVP_CIPHER_CTX_init(ctx); ctx = EVP_CIPHER_CTX_new();
if (ctx == NULL) {
*bytes_written = 0;
return;
}
EVP_DecryptInit_ex(ctx, EVP_aes_128_cbc(), NULL, key, iv); EVP_DecryptInit_ex(ctx, EVP_aes_128_cbc(), NULL, key, iv);
EVP_CIPHER_CTX_set_padding(ctx, 0); EVP_CIPHER_CTX_set_padding(ctx, 0);
if (verbose >= 5) if (verbose >= 5)
{ {
printbuf(iv, 16, "decrypting with this IV"); printbuf(iv, 16, "decrypting with this IV");