From fb5d8559e656ad0acfcc9163535a309224fdbdea Mon Sep 17 00:00:00 2001 From: Zdenek Styblik Date: Sat, 13 Jul 2013 03:51:49 +0000 Subject: [PATCH] ID: 101 - 'lib/ipmi_sol.c' - possible int *flow Don't make ref out of ref -> segfault. --- ipmitool/lib/ipmi_sol.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ipmitool/lib/ipmi_sol.c b/ipmitool/lib/ipmi_sol.c index cdb10c4..b7c5265 100644 --- a/ipmitool/lib/ipmi_sol.c +++ b/ipmitool/lib/ipmi_sol.c @@ -659,7 +659,7 @@ int ipmi_sol_set_param_isvalid_uint8_t( const char *strval, uint8_t maxval, uint8_t *out_value) { - if (str2uint(strval, &out_value) != 0 || (*out_value < minval) + if (str2uint(strval, out_value) != 0 || (*out_value < minval) || (*out_value > maxval)) { lprintf(LOG_ERR, "Invalid value %s for parameter %s", strval, name);