bb632de830
Fixes bug ID:3484936 - missing user input validation in 'lib/ipmi_session.c'
...
It replaces strtol() calls with str2uint() ones and adds error messages if
invalid input is given.
2012-02-06 12:48:09 +00:00
78d7ae8d88
Removes debug printf() left by somebody in 'lib/ipmi_sdr.c' and crapping all
...
over the regular output.
2012-02-06 11:49:59 +00:00
904cbebce5
Fixes ID:3421347 Sensor list command should use channel field from SDR
...
Running an "ipmitool sensor list" command on a system where remote sensors are
not on channel 0 results in unexpected behavior. The SDR functions were fixed
in January of 2009 (lib/ipmi_sdr.c, rev 1.86) to use target I2C addresses and
LUNs for non-BMC-owned sensors. Sensors owned by satellite controllers on other
channels were read as if they were on channel 0.
I've fitted patch, posted alongside bug report, to CVS version.
2012-02-06 09:51:58 +00:00
09fc12a929
Fixes silly mistake I made in comparison in functions str2long() and
...
str2ulong() in 'lib/helper.c'.
Fixes: end_ptr -> *end_ptr
2012-01-26 14:30:53 +00:00
2902784cf3
Fixes possible *flows via user input in 'lib/ipmi_chassis.c' which may(and do)
...
lead to unpredicted/unwanted behaviour.
Commit replaces use of atoi() with str2NUM() functions and adds error messages
if invalid input supplied.
2012-01-26 12:50:26 +00:00
a9b78ab736
Fixes missing semicolons at the end of the line in 'include/ipmitool/helper.h'.
2012-01-26 10:04:04 +00:00
3d5e378e90
Commit adds input validation for -N(timeout) and -R(retry) parameters. It
...
changes types of variables 'timeout' and 'retry' to types wich should be passed
to called functions.
2012-01-26 09:22:57 +00:00
d4c2577a16
Commit updates list of functions in 'include/ipmitool/helper.h'.
...
Adds str2NUM() functions I've added earlier in 'lib/helper.c'.
2012-01-26 09:15:08 +00:00
f681fe89b7
Adds function str2uint() to convert from string to uint32_t with checks for valid input.
2012-01-26 08:22:11 +00:00
ca062647be
Adds use of str2NUM() functions for the most of user input parameters in
...
'lib/main.c'. Error messages added as well.
2012-01-25 15:27:13 +00:00
3423c1d92f
'lib/helper.c' - str2uchar() - renamed arg_long -> arg_ulong
2012-01-25 15:09:49 +00:00
e0b75fba8c
Adds function str2uint() to convert string to uint16_t with checks for valid input.
2012-01-25 14:57:12 +00:00
7dd969f2c6
Replaces use of atoi() for parameters d, p and C with str2int() function and
...
adds range validation for these parameters.
2012-01-25 12:56:36 +00:00
a9c68c76c3
Remove extra new-lines from error messages in 'src/ipmievd.c'.
2012-01-25 12:08:46 +00:00
e29166e4e8
Add input validation for time-out parameter in 'src/ipmievd.c'.
2012-01-25 11:53:41 +00:00
9217312cc4
Fixes missing return for selwatch_wait() in 'src/ipmievd.c'.
...
Added return 0;''.
2012-01-25 09:12:42 +00:00
fbf75dd075
Adds check whether PID fp was acquired or not. If not, then init logging
...
facility, print error and exit.
2012-01-25 09:02:59 +00:00
bf1e9952e1
Fixes ignorance of existing PID file which results in PID being overwritten.
...
Start of the daemon has shifted couple lines bellow, because it doesn't make
sense to start daemon first and check existence of PID file later.
2012-01-24 13:59:58 +00:00
5ed7f6ac0a
Fixes CVE-2011-4339 - world writeable PID file
...
Adds proper umask() before writing PID file.
2012-01-24 13:26:56 +00:00
b6d2f7e302
Commit introduces set of functions to safely convert user input to numbers.
...
These functions utilize strtol() and strtoul() to convert input and check for
invalid input as well as for *flows.
Functions added: str2long(), str2ulong(), str2int(), str2short(), str2uchar();
2012-01-24 12:14:21 +00:00
bb40822d34
Replace whitespace indentations with tabs in 'lib/helper.c'.
2012-01-21 08:31:09 +00:00
835fe8886c
Replace whitespaces with tabs, remove trailing spaces/tabs and other formatting inconsistencies.
2012-01-21 07:19:52 +00:00
55ee48696a
Remove hardcoded CR('\r') from 'lib/ipmi_delloem.c'.
2012-01-21 05:38:49 +00:00
fedd6f187f
Remove hardcoded CR('\r') from 'lib/ipmi_ekanalyzer.c'.
2012-01-21 05:37:41 +00:00
a6cad674d0
Remove hardcoded CR('\r') from 'lib/ipmi_fru.c'.
2012-01-21 05:36:58 +00:00
c1e46b35cd
Remove hardcoded CR('\r') from 'lib/ipmi_fwum.c'.
2012-01-21 05:35:49 +00:00
a65d5add66
Remove hardcoded CR('\r') from 'lib/ipmi_hpmfwupg.c'.
2012-01-21 05:34:33 +00:00
ba6f2fe2a2
Remove hardcoded CR('\r') from 'lib/ipmi_isol.c'.
2012-01-21 05:32:24 +00:00
ebab3919ef
Remove hardcoded CR('\r') from 'lib/ipmi_kontronoem.c'.
2012-01-21 05:31:16 +00:00
e6db6a04b5
Remove hardcoded CR('\r') from 'lib/ipmi_main.c'.
2012-01-21 05:29:41 +00:00
fb75f8d8fc
Remove hardcoded CR('\r') from 'lib/ipmi_picmg.c'.
2012-01-21 05:28:39 +00:00
9660e90ad2
Remove hardcoded CR('\r') from 'lib/ipmi_sol.c'.
2012-01-21 05:27:14 +00:00
e0ed4351d0
Remove hardcoded CR('\r') from 'lib/ipmi_tsol.c'.
2012-01-21 05:26:23 +00:00
619233e14b
Remove hardcoded CR('\r') from 'lib/log.c'.
2012-01-21 05:24:19 +00:00
7c9baca424
Remove hardcoded CR('\r') from 'lib/helper.c'.
2012-01-21 05:23:22 +00:00
c9b53b1b32
Fix possible buffer overflow in buf2str() in 'lib/helper.c'.
2012-01-20 19:19:22 +00:00
54cc84adf2
Fix typo in 'picmg power get help' output. Replaces 'powert' with 'power'.
2012-01-20 18:57:14 +00:00
37d672412d
Remove unused variable in 'lib/ipmi_chassis.c'
2012-01-20 18:51:24 +00:00
1b1efca7e2
- Bug in the existing code where it keeps on adding same command/seq pair
...
- Add timeout / retry to LAN
-- Thanks to Harshad Parbhu --
2011-11-22 13:43:38 +00:00
c9bd5b5b90
- Bug in the existing code where it keeps on adding same command/seq pair
...
- Add retry / timeout options for LAN
2011-11-22 13:42:36 +00:00
19295a5483
Add new Dell OEM commands and update man page
2011-10-06 16:26:18 +00:00
d06ddcd28b
Add Dell OEM network commands
2011-09-21 20:59:04 +00:00
335d444213
- Clarify DCMI get limit activation (add if activate or not).
...
- Change some string to remove underscore (was looking more like coding style string)
2011-08-26 18:57:18 +00:00
0cbc38746a
- Add DCMI module (Data Center Management Interface)
...
* Module retreive from application DCMITool that is originally based on IPMITool.
* File ipmi_dcmi.c does not have a restrictive license and as per the license on
* the top of the file, the software is provided "AS IS".
2011-06-28 13:50:59 +00:00
348cd98287
- Add support for AMC type 17h record.
2011-05-17 13:20:06 +00:00
eb22beb537
Add support for drive backplane SetLED functionality
2011-04-14 20:23:59 +00:00
019a9de626
Re-adding C3 fix
2011-03-30 19:52:38 +00:00
c5c6315525
Improvement to hpm upgrade during activation. This resolves issue where activation seems to have failed because ipmitool received an unsupported completion code.
2011-03-10 19:01:35 +00:00
7fc4ce6eae
Fix in fru edit
...
It is now possible to edit field 0 of sections
2011-03-08 19:38:03 +00:00
061272f595
- Fixed issues with fru edit.
...
Allocated memory for fru is cleared.
Added check to prevent copying data from old fru beyond end of allocated memory
Code now keeps track of old and new product section length. Used to determine position of remaining bytes.
2011-03-08 16:17:58 +00:00
