339 Commits

Author SHA1 Message Date
B BALAJI SINGH
052655cd91 ID:456 - Unable to disable the VLAN ID using ipmitool
Currently, when a LAN parameter set command is sent through ipmitool, the
corresponding parameter data is requested and compared to the command to verify
that the data was written correctly. Since we do send the VLAN ID in this return
data, regardless of whether VLAN is disabled or not, this mismatch between
requested and received parameters causes ipmitool to retry the command 10 times
and return an error.

ipmitool is sending "0x00 0x00" reading back data from BMC as "0x01 0x00" which
is NOT matching & hence pops up the error /warning "LAN Parameter Data does not
match! Write may have failed."
After 10 retries when we check "ipmitool lan print" VLAN ID is disabled
successfully.
2016-08-31 19:34:18 +02:00
Dmitry Rakhchev
fa2c1550b9 ID: 459 - Fix reading FRU on Artesyn (Emerson) shelf manager, MF105.
Treat 0xC7 as an indication that requested data length in the
FRU read shall be decreased.
2016-08-28 10:21:55 +02:00
Zdenek Styblik
cc9a6b3964 ID:457 - Display User ID enable/disable status
Commit implements `Enable status` which shows/is in alignment with (22.27) Get
User Access Command and displays User ID Enable/Disable status of given User ID
at given channel.
2016-08-21 12:17:10 +02:00
Dan Gora
ea471ed5fa ID:454 - Add support for PICMG 3.1 R2.0 Link Types and Link Classes.
PICMG 3.1 R2.0 introduces new a new Link Class field in the FRU
Link Descriptors which is the upper 4 bits of the Link Type field.
This new Link Class field specifies SERDES lanes with 10.3125Gbd
signalling rate.

It also introduces the new Base-KX and Base-KX4 types which are the
new IEEE replacements for the PICMG 3.0 Base-BX and Base-BX4 types.

This patch decodes these new types and fields and will print out
proper descriptions for each one based on PICMG 3.1 R2.0
2016-08-21 09:48:55 +02:00
Dmitry Rakhchev
e30c357db7 ID:375 - Add lan6 subcommand to handle IPv6 LAN parameters 2016-08-21 08:59:27 +02:00
Zdenek Styblik
95eb252ecd ID:261 - Fix err. output consistency for % ipmitool chassis INV_PARAM; 2016-07-31 20:19:30 +02:00
Zdenek Styblik
2c99bf69ec Fix missing goto out_free; when ipmi_parse_hex() returns (-1) 2016-07-31 08:56:38 +02:00
Dmitry Rakhchev
34711329c2 Add mac2str() and str2mac() to print/parse MAC address 2016-07-31 08:52:40 +02:00
Dmitry Rakhchev
2f76ab3d3a Export find_lan_channel() as global 2016-07-31 08:52:40 +02:00
Dmitry Rakhchev
7f8d37493f Rewrite code with the notion that Kg is binary data, not string
- use uint8_t as the storage type
  - allocate kgkey on stack
  - do not treat incoming kgkey as 0-trminated string in
    ipmi_intf_session_set_kgkey()
2016-07-31 08:52:40 +02:00
Dmitry Rakhchev
f9211f8ed9 Moved ipmi_parse_hex() to helper.c 2016-07-31 08:52:40 +02:00
Dmitry Rakhchev
9a6ba64651 Extend buf2str to allow separator 2016-07-31 08:52:40 +02:00
Bjoern Spruck
f8a711b9e8 ID:452 - Add PICMG extension 5.x for PICMG extension check
PICMG extension 5(UTCA, MicroTCA) is not detected as valid extension.
The following patch fixes that at one place. In the second place the board type
is detected in a similar way, but it isn't clear if a patch is needed there, too.
2016-07-31 07:29:49 +02:00
KC Li
fcf7445bce ID:451 - Modify the memory ecc error display of SEL for new supermicro motherboards. 2016-07-31 07:25:30 +02:00
Mamatha Inamdar
a3bec1d365 ID:449 - ipmitool close console session for sol deactivate command
In the new version of ipmitool 1.8.15 and above, sol deactivate command was not
closing the session, This patch is to fix close console session When we issue
sol deactivate command.
2016-06-29 20:06:29 +02:00
Zdenek Styblik
8bd9659101 ID:230 - check return value of malloc() in lib/ipmi_ekanalyzer.c
Return value of malloc() must be checked. Commit mends this.
2016-06-11 21:30:04 +02:00
Zdenek Styblik
9341982a38 ID:335 - Check return value of fseek(), prevent segfault
Commit adds a check as a workaround for segfault reported in ID:335. However,
the proper fix is to rewrite parts of lib/ipmi_hpmfwupg.c not to put whole
firmware image into memory. Also, MD5 checksum part needs to be rewritten,
because it won't work for large firmware images.
2016-06-09 12:01:48 +02:00
Zdenek Styblik
4ecac48c68 Revert "ID:335 - Check return value of fseek(), prevent segfault"
This reverts commit 6d8ad594ccd582ac0a004e55c8459409376fc264 because of wrong
e-mail address in commit.
2016-06-09 12:01:29 +02:00
Zdenek Styblik
6d8ad594cc ID:335 - Check return value of fseek(), prevent segfault
Commit adds a check as a workaround for segfault reported in ID:335. However,
the proper fix is to rewrite parts of lib/ipmi_hpmfwupg.c not to put whole
firmware image into memory. Also, MD5 checksum part needs to be rewritten,
because it won't work for large firmware images.
2016-06-09 11:48:29 +02:00
Boris Ranto
c89be0354a ID:446 - Fix broken firewall reset iterator
The netfn structures are populated sequentially in the _gather_info
function and they are accessed only by even indices (and to the double
of its real length). This results in a segmentation fault if you run

* ipmitool firewall reset

This patch fixes the behaviour so that the ipmi_firewall_reset function
treats the structure the same way as the rest of the code does.

Signed-off-by: Boris Ranto <branto@redhat.com>
2016-06-06 06:43:35 +02:00
Zdenek Styblik
7e991a18e0 ID:355 - Fix statements without effect in lib/ipmi_ekanalyzer.c 2016-05-30 20:38:46 +02:00
Zdenek Styblik
b42c16d9dc ID:355 - Fix printf format in lib/ipmi_sunoem.c 2016-05-30 20:38:17 +02:00
Zdenek Styblik
55834ec3aa ID:355 - Fix different pointer type in lib/ipmi_picmg.c
... just change `char` to uint8_t, really.
2016-05-30 20:36:37 +02:00
Zdenek Styblik
a7b0c213f9 ID:355 - Fix missing struct initializers in lib/ipmi_firewall.c 2016-05-30 20:19:33 +02:00
Zdenek Styblik
70253df032 ID:355 - Fix signedness warnings in lib/ipmi_sdr.c 2016-05-30 06:42:13 +02:00
Zdenek Styblik
ec8ba928d4 ID:355 - Comment out statement without effect in lib/ipmi_sel.c 2016-05-30 06:41:38 +02:00
Zdenek Styblik
f62a16f7f2 ID:355 - Fix printf() related warnings in lib/ipmi_delloem.c 2016-05-30 06:38:09 +02:00
Zdenek Styblik
681bc21d32 ID:355 - Move section_id from ipmi_fru. to ipmi_fru.c
... since that's the only place where it's used right now. It might be worth to
rework this concept.
2016-05-29 21:03:25 +02:00
Zdenek Styblik
8ca47f21ca ID:441 - Add support for HMAC_MD5 and HMAC_SHA256
Commit adds support for cipher suites 6/7/8 (HMAC-MD5) and cipher
suites 15/16/17 (HMAC_SHA256).
This also fixes:
* ID:442 - IPMI_AUTH_RAKP_HMAC_MD5 support in lanplus
* ID:141 - RMCP+ Cipher-suite 17 not supported

Original author Liebig Holger(Fujitsu).
Code cleanup done by Florian Breu and Zdenek Styblik.
2016-05-28 13:32:45 +02:00
Zdenek Styblik
b74c20c5d5 ID:312 - Fix bitmask in _ipmi_set_pef_policy_entry()
Commit fixes wrong bitmask in _ipmi_set_pef_policy_entry(). Also, bitmask
defined by macro is used in _ipmi_get_pef_policy_entry() as well.
2016-05-22 18:51:27 +02:00
Zdenek Styblik
ebe6b0ce48 ID:287 - Fix print-out of DDR3 SDRAM Serial Number
Commit fixes print-out of DDR3 SDRAM Serial Number. This was caused by printing
out more bytes/chars and some weird pointer tricks.
2016-05-17 20:54:09 +02:00
Dmitry Bazhenov
b44366e92d ID:400 - Add support for VITA-specific sensor types and events.
Reworked event type code/sensor type parsing in order to support
VITA-specific extensions. Added VITA-specific sensor-specific event
types and VITA-specific sensor types.
2016-05-17 20:49:06 +02:00
Zdenek Styblik
e88e5c8186 ID:287 - Remove trailing white-spaces from dimm_spd.c
Commit removes trailing white-spaces from lib/dimm_spd.c
2016-05-16 21:55:52 +02:00
Zdenek Styblik
107e6affd0 ID:312 - BREAKING CHANGE - Re-design of PEF user interface
Commit re-works user interface of PEF module as well as internal functions.
Not all of the functionality is implemented as the main aim was interface
layout.
It's possible this commit introduces some breaking changes.

Changes are based on patch submitted by Jordan Hargrave, Dell Inc.
2016-05-16 19:18:19 +02:00
Zdenek Styblik
5fca596492 Re-work ipmi_mc_get_guid() and turn it into reusable code 2016-05-16 19:18:19 +02:00
Boris Ranto
ccfa5aec4f ID 408 - fix sel list last X listing
The events can be removed as desired on certain machines so the only way
to get the proper last X events is to traverse them all not outputting
the first NR_EVENTS - X events.

Signed-off-by: Boris Ranto <branto@redhat.com>
2016-05-03 06:32:07 +02:00
Zdenek Styblik
1636dbcf0c ID 440 - remove obsolete headers from lib/ipmi_sunoem.c
Commit removes headers which have been obsoleted by POSIX.1-2001.
2016-04-24 18:24:14 +02:00
Dmitry Bazhenov
9f2072e6c3 ID 440 - Fix 'unknown type name fd_set" error.
Cygwin64 build fails at 'lib/ipmi_sunoem.c' due to
missing include. This patch fixes the issue.
2016-04-24 18:10:58 +02:00
Zdenek Styblik
d57bf32668 Check rsp->data_len in ipmi_sel_get_info()
Commit adds check of response's data_len in ipmi_sel_get_info() as returned data
length is unconditional. If incorrect, resp. short, data_len is returned, we
might end up reading memory at places we're not supposed to.
2016-04-12 21:09:52 +02:00
Dennis Schridde
0d6a45357b Fix several implicit function declarations in lib/ipmi_fru.c
* ipmi_intf_get_max_request_data_size
* ipmi_intf_get_max_response_data_size
* ipmi_spd_print_fru
2016-04-11 17:18:46 +02:00
Dennis Schridde
d1b0e68515 Fix warning: suggest parentheses around '+' inside '<<' in lib/ipmi_main.c 2016-04-11 17:18:46 +02:00
Dennis Schridde
4520b6ff0e Fix several implicit declarations of functions in lib/ipmi_main.c
* ipmi_vita_ipmb_address
* vita_discover
* ipmi_kontronoem_set_large_buffer
* ipmi_intf_set_max_request_data_size
2016-04-11 17:18:46 +02:00
Dennis Schridde
a40737f856 Fix implicit declarations of functions 'HpmfwupgPreUpgradeCheck' and 'ipmi_intf_get_max_request_data_size' in lib/ipmi_hpmfwupg.c 2016-04-11 17:18:46 +02:00
Dennis Schridde
a40d51abff Fix implicit declaration of function 'get_nic_selection_mode_12g' in lib/ipmi_delloem.c 2016-04-11 17:18:46 +02:00
Dennis Schridde
baa2c08ab3 Fix implicit declarations of functions 'ipmi_intf_set_max_request_data_size' and 'ipmi_intf_set_max_response_data_size' in lib/hpm2.c 2016-04-11 17:18:40 +02:00
Dennis Schridde
19423c68d0 Fix implicit function declaration of ipmi_intf_get_max_response_data_size in lib/ipmi_sdr.c 2016-04-11 17:18:40 +02:00
Dennis Schridde
0f896e36f2 Fix "redirecting incorrect #include <sys/poll.h> to <poll.h>" warning with musl libc 2016-04-11 17:18:40 +02:00
Vasant Hegde
c7169bc27e ID:437 - sel: Fix "sel time set <time>"
Presently 'sel time set' doesn't account 'minute' difference between timezone.
So depending on host timezone it may set time to +/-30 mins. This patch adds
minute difference to delta_hour caluclation so that it sets time properly.

output without patch:
  # ./ipmitool sel time get
  03/24/2016 12:34:03
  # ./ipmitool sel time set "03/24/2016 12:34:03"
  03/24/2016 12:04:03
  # ./ipmitool sel time get
  03/24/2016 12:06:09

output with patch:

  # ./ipmitool sel time get
  03/30/2016 08:49:47
  # ./ipmitool sel time set "03/30/2016 08:09:47"
  03/30/2016 08:09:47
  # ./ipmitool sel get
  03/30/2016 08:09:57

Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
2016-04-10 15:57:07 +02:00
Dong Debin
d6ca800da2 ID:430 - Change Nokia Siemens Networks to Nokia Solutions and Networks 2016-03-27 20:28:58 +02:00
Zdenek Styblik
8fe8a5c74c Fix automake compatibility warnings
Commit fixes future compatibility warnings from automake.
2016-03-16 19:41:38 +01:00