deepblue/ipmitool
1
0
Fork 0
mirror of https://github.com/ipmitool/ipmitool.git synced 2025-05-10 18:47:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
1,886 Commits 8 Branches 28 Tags
Commit Graph

1886 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Zdenek Styblik
4dfb15281e Remove dead code in fru_area_print_product() - CID#1148999 2015-01-19 14:47:46 +01:00
Zdenek Styblik
7bd7c4fdd1 Remove dead code in fru_area_print_board() - CID#1149001 2015-01-19 14:46:09 +01:00
Zdenek Styblik
f0acdf1b50 Remove dead code in fru_area_print_chassis() - CID#1149000 
I guess this really can't happen.
 2015-01-19 14:44:33 +01:00
Zdenek Styblik
ece5e55745 Fix resource leak in fru_area_print_product() - CID#1149046 2015-01-19 06:43:42 +01:00
Zdenek Styblik
99721b52e4 Fix resource leak in fru_area_print_chassis() - CID#1149047 2015-01-19 06:42:05 +01:00
Zdenek Styblik
0b54fac782 Fix resource leak in fru_area_print_board() - CDI#1149048 2015-01-19 06:40:33 +01:00
Zdenek Styblik
312f95930d Fix uninitialized struct in ipmi_fru_upg_ekeying() - CID#1149065 2015-01-19 06:37:07 +01:00
Zdenek Styblik
d36cfcb817 ID:355 - Fix formatting warning in get_cmdline_ipaddr() 
Commit also adds validation prior casting down to uint8_t.
 2015-01-17 12:25:50 +01:00
Zdenek Styblik
33f9336e85 ID:355 - Fix compiler warnings 
Commit removes all unused variables reported by compiler.
 2015-01-17 11:44:46 +01:00
Zdenek Styblik
6febd10121 Put functions in ipmi_channel.c in A-Z order 2015-01-17 07:11:07 +01:00
Zdenek Styblik
6b8d55d68b Re-work ccode eval in ipmi_get_channel_medium() 
Commit re-works ccode eval in ipmi_get_channel_medium() as the previous one
didn't work and led to dead-code.
 2015-01-16 21:05:56 +01:00
Zdenek Styblik
12b85b3c7b Init user_access_t struct in ipmi_user_priv() 2015-01-16 20:49:06 +01:00
Zdenek Styblik
0ff2d6e464 ID:357 - out-of-bound access in DDR4 code 
Commit increases RAW_SPD_SIZE from 256 to 512 as an attempt to fix OOB in
ipmi_rawspd_main(), resp. ipmi_spd_print().
 2015-01-16 20:18:41 +01:00
Zdenek Styblik
dab7f5bf81 Remove unused variable from ipmi_get_channel_cipher_suites() 
Commit removes unused variable oem_record from ipmi_get_channel_cipher_suites().
 2015-01-16 20:11:29 +01:00
Zdenek Styblik
6c3f60e57c Remove get_channel_access_rsp and get_channel_info_rsp structs 
Commit removes unused structures get_channel_access_rsp and
get_channel_info_rsp as they were replaced.
 2015-01-16 20:08:46 +01:00
Zdenek Styblik
278dc84b22 Print error message to STDERR in ipmi_channel.c 
Print error message to STDERR and not STDOUT in ipmi_channel_main().
 2015-01-16 20:07:26 +01:00
Zdenek Styblik
0801b4588d Hook ipmi_get_channel_medium() to new _ipmi_get_*() functions 
Commit hooks ipmi_get_channel_medium() to new _ipmi_get_*() functions.
 2015-01-16 20:04:31 +01:00
Zdenek Styblik
56aa025dc2 Hook ipmi_get_channel_info() to _ipmi_get_*() 
Commit hooks ipmi_get_channel_info() to new _ipmi_get_*() functions.
 2015-01-16 20:03:07 +01:00
Zdenek Styblik
238d3c4ea9 Add _ipmi_get_channel_access() and _ipmi_get_channel_info() 
Commit adds _ipmi_get_channel_access() and _ipmi_get_channel_info() as well as
supporting structures.
 2015-01-16 20:01:50 +01:00
Zdenek Styblik
69f668309b ipmi_get_user_access() - change var name 'userid' to 'user_id' 
Commit changes variable/param name from 'userid' to 'user_id' in order to keep
consistency.
 2015-01-13 13:36:25 +01:00
Zdenek Styblik
585cb7c83d Add documentation to 'getaccess' and 'setaccess' functions 2015-01-11 09:39:13 +01:00
Zdenek Styblik
708be8bc45 Hook ipmi_user_priv() to _ipmi_set_user_access() 
Commit hooks ipmi_user_priv() to _ipmi_set_user_access(). Later got extended for
'change_priv_limit_only', because of the former.
Commit removes ipmi_user_set_userpriv(), because it's not used anywhere.
 2015-01-09 12:48:35 +01:00
Zdenek Styblik
d6deeb264e Hook ipmi_print_user_list() and friends to _ipmi_* functions 
Commit hooks ipmi_print_user_list() and related functions to new _ipmi_*
functions. It also removes old/unused functions and user_access_rsp struct.
 2015-01-09 11:40:52 +01:00
Zdenek Styblik
bcb96209c5 ID:355 - Fix compiler warnings in dimm_spd.c 
* remove unused variable
* add (...) as suggested
 2015-01-09 08:00:07 +01:00
Zdenek Styblik
8227384c02 ID: 355 - Fix compiler warnings for Dummy Interface 
Commit fixes compiler warnings for Dummy Interface:
* fix variable name
* remove unused variables
 2015-01-09 07:31:55 +01:00
Zdenek Styblik
39fb1af285 ID:355 - Fix Enumeration value not handled in ipmi_get_event_desc() 
Commit fixes ``Enumeration value not handled'' in ipmi_get_event_desc() by
adding 'default' to the switch.
 2015-01-09 07:23:05 +01:00
Zdenek Styblik
faae8fd247 Fix identical code for diff branches in DellOEM - CID#1261326 
Commit adds error messages in order to fix CID#1261326.
 2015-01-09 07:01:51 +01:00
Zdenek Styblik
b6ec5072f4 Remove length checks in get_supermicro_evt_desc() 
Commit removes length checks in get_supermicro_evt_desc(), because they make no
sense. Fixes out-of-bound-reads CID#1149029 and CID#1149030
 2015-01-08 22:44:55 +01:00
Zdenek Styblik
fb36c69391 ipmi_print_user_summary() to utilize _ipmi_get_user_access() 
Commit changes ipmi_print_user_summary() to utilize _ipmi_get_user_access() and
user_access_t instead of user_access_rsp.
 2015-01-08 21:54:41 +01:00
Zdenek Styblik
d099dca9c5 Fix/remove pointer cast in _ipmi_set_user_access() 
Commit removes invalid pointer in _ipmi_set_user_access().
 2015-01-08 21:29:30 +01:00
Zdenek Styblik
af276d4082 Fix out-of-bound-reads in get_supermicro_evt_desc() 
CID#1149029 and CID#1149030
 2015-01-08 20:22:15 +01:00
Zdenek Styblik
e4be291c65 Re-work 'channel getaccess' and 'channel setaccess' 
Commit is a re-work of 'channel getaccess' and 'channel setaccess'. These are
using _ipmi_* now. Also, bitfields and two structs are replaced by one unified
struct.
 2015-01-08 19:45:22 +01:00
Zdenek Styblik
bb35d370ba Add eval_ccode() into helper 
Commit adds eval_ccode() into helper in order to save some code repetition on
evaluation of retvals from _ipmi_* functions.
 2015-01-08 19:43:27 +01:00
Zdenek Styblik
31f9d4c635 Add _ipmi_get_user_access() and _ipmi_set_user_access() 
Commit adds reusable functions _ipmi_get_user_access() and
_ipmi_set_user_access().
 2015-01-08 16:44:18 +01:00
Zdenek Styblik
6d1afbf3a7 Add _ipmi_get_user_name() 
Commit adds function _ipmi_get_user_name() which does nothing but fetches User
Name as per 22.29. There are no print-outs when the called.
 2015-01-08 16:13:51 +01:00
Zdenek Styblik
d9acbc4cd0 ID:358 - check data length in else branch of ipmi_spd_print() 
Commit adds data length check into '} else {' branch of ipmi_spd_print() in
order to avoid out-of-bound access.
 2015-01-04 14:58:37 +01:00
Jim Mankovich
9811f79eae ID:357 - out-of-bound access in DDR4 code 
ID:356 -  DIMM4 Die Count is unreachable
 2015-01-01 09:16:34 -07:00
Zdenek Styblik
2d66f8d5cf Change expression in ipmi_pef_list_policies() in order to silence Coverity 2014-12-31 12:23:56 +01:00
Zdenek Styblik
8775af38f5 Remove dead code - rsp can't be NULL at this point - CID#1149005 2014-12-31 05:53:24 +01:00
Zdenek Styblik
9fc4a39fda Remove dead(duplicate) code from ipmi_sol_main() - CID#1148996 2014-12-31 05:47:00 +01:00
Zdenek Styblik
a6957f875c Delete dead code from ipmi_sunoem_echo() - CID#1261338 
Commit removes a dead code from ipmi_sunoem_echo(). Code didn't make any sense
in given context.
 2014-12-30 20:12:11 +01:00
Zdenek Styblik
4ef4618366 Remove commented-out code in ipmi_picmg_clk_set() - CID#1261339 
Originally ``Printf arg type mismatch''.
 2014-12-30 20:07:12 +01:00
Zdenek Styblik
8ac8361aca Fix Identical code for different branches in ipmi_tsol_main() - CID#1261346 
Commit adds error message and retval (-1) for an invalid tsol command/parameter.
 2014-12-30 20:00:56 +01:00
Zdenek Styblik
fb69b5dc9e Fix Assign instead of compare in KfwumGetDeviceInfo() - CID#1149034 2014-12-30 18:20:34 +01:00
Zdenek Styblik
c2e65d0dce Fix dead code in ipmi_firewall_reset() - CID#1261342 2014-12-30 17:40:07 +01:00
Zdenek Styblik
12eeca602c Fix missing return in ipmi_kontronoem_main() - CID#1261317 2014-12-30 17:20:49 +01:00
Zdenek Styblik
c076fde0a6 Fix file descriptor leak in ipmi_exec_main() - CID#1149040 2014-12-30 16:21:52 +01:00
Zdenek Styblik
ecfaeb2706 Change expression in ipmi_pef_get_info() in order to silence Coverity 
Commit changes expression from ``if (!ptbl)'' to ``if (ptbl != NULL)'' in order
to silence Coverity. CID#1149049
 2014-12-30 16:02:21 +01:00
Zdenek Styblik
61db4df637 Fix memory leak in ipmi_ek_display_board_info_area() - CID#1149051 2014-12-30 15:51:49 +01:00
Zdenek Styblik
e37e3ab7de Fix memory leak in get_supermicro_evt_desc() 
Commit fixes memory leak in get_supermicro_evt_desc() - CID#1149050
 2014-12-30 15:43:55 +01:00