Zdenek Styblik
0a1f5c03e5
Replace deprecated bzero() with memset()
...
Commit replaces deprecated bzero() with memset().
2014-12-23 05:46:28 +01:00
Zdenek Styblik
140add9d77
Fix user input validation in Channel and User sub-commands
...
Commit fixes validation of user input in Channel and User sub-commands.
2014-12-22 18:21:51 +01:00
Zdenek Styblik
0562c809af
Cleanup if/else in ipmi_channel_main()
2014-12-22 08:49:58 +01:00
Zdenek Styblik
a87b2ccc67
Cleanup of code formatting in ipmi_channel.c
...
At least a bit.
2014-12-22 07:57:18 +01:00
Zdenek Styblik
ad77da2065
ID:349 - user set password - add option to choose 16/20 byte password
...
Commit adds option to 'user set password' to choose whether password should be
stored as 16 byte or 20 byte. From now on, it's possible to store even 5 bytes
long password as 20 byte password which should make it useless for IPMI v1.5
auth/sessions.
2014-12-20 16:40:55 +01:00
Zdenek Styblik
6e6a04f971
Make user User Privilege Limit is within range
...
Despite the fact we could leave this up to IPMI stack, we won't do that.
Therefore, is_ipmi_user_priv_limit() is added and user provided value checked.
2014-12-20 13:57:06 +01:00
Zdenek Styblik
befb21497f
Create ask_password() and re-use code
...
Commit add function ask_password() which leads to code re-usability and shedding
couple lines of otherwise redundant code.
2014-12-20 13:43:38 +01:00
Zdenek Styblik
1d1ce49bf4
Fix 'user help' output
...
Commit fixes padding of 'user help' output. Also, list of expected values of
privilege leves have been added.
2014-12-19 09:57:49 +01:00
Zdenek Styblik
50bd7d01a8
Don't use tmp variable since it's not necessary in ipmi_user_test()
2014-12-19 08:49:20 +01:00
Zdenek Styblik
4d3decc4c0
Split ipmi_user_main() into smaller functions
...
Commit splits ipmi_user_main() into smaller functions. Hopefully, this will be
better than giant main() function.
2014-12-18 18:40:51 +01:00
Zdenek Styblik
f8ce85ee6c
Clenaup formatting in ipmi_user_main()
2014-12-09 18:59:37 +01:00
Zdenek Styblik
2aa5d8c902
Code cleanup in ipmi_user_main()
...
This is just a tip of an iceberg, really.
2014-12-09 18:59:36 +01:00
Zdenek Styblik
3c34aa0e1d
Cleanup formatting in ipmi_user_main()
2014-12-09 18:59:36 +01:00
Zdenek Styblik
a58a627fae
Remove trailing white-spaces in ipmi_user.c
2014-12-09 18:59:36 +01:00
Zdenek Styblik
aaf98b89d5
ID:348 Add support for the "System Firmware Version"
...
Add support for the "System Firmware Version" parameter selector (1) to the "Get
System Info Parameters" command ("mc getsysinfo system_fw_version"). The "mc
getsysinfo" command was already implemented and supported, but strangely, only
standard parameter selecter values 2, 3, 4 and Dell-defined parameters were
supported; the standard parameter value 1 (system firmare version) was not
supported.
2014-12-05 14:15:02 +01:00
Zdenek Styblik
7cd86aaf1e
ID:347 - Incorrect reserved channel number
...
Fix validation of IPMI channel numbers according to IPMIv2.0 rev1.1 and update
documentation as well.
2014-12-05 13:39:31 +01:00
Zdenek Styblik
dd4cab8153
ID:343 - Remove AC_FUNC_MALLOC
...
Fix cross-compile build error regarding to 'rpl_malloc'.
ipmitool actually does not need the GNU's malloc(0) behavior.
So, remove AC_FUNC_MALLOC from AC-script in order to help
cross-compiling ipmitool without need to directly specify
ac_cv_func_malloc_0_nonnull environment variable.
2014-12-05 13:33:12 +01:00
Zdenek Styblik
d671052143
ID:345 - Do not do several close session retries when catching SIGINT
...
Reduce number of retries to 1 when closing interface on SIGINT.
This reduces time needed to terminate the LAN connection.
2014-11-29 18:06:13 +01:00
Zdenek Styblik
e9c3de03c3
ID:346 - lib/ipmi_sdradd.c ipmi_sdr_read_record has a file descriptor leak
...
'lib/ipmi_sdradd.c' ipmi_sdr_read_records() opens a file descriptor and never
closes it. Here is a patch in use by SGI for quite some time now. Suggested
patch attached.
2014-11-29 17:52:18 +01:00
Zdenek Styblik
1cf65c3236
ID:344 - Fix HPM.2 long message support
...
Due to a typo in the result checking. HPM.2 long message support detection does
not work.
2014-11-29 17:45:41 +01:00
Zdenek Styblik
0eaa2eae51
ID:343 - Print actual sensor thresholds in 'sensors' comand
...
Use Get Sensor Threshold command for obtaining thresholds, since SDR records may
contain not actual threhsolds.
2014-11-29 17:44:07 +01:00
Zdenek Styblik
f56d740d98
ID: 307 - Intel I82751 super pass through mode fixup
...
The patch adds missing check for the Intel i82751 MAC being in the super
pass-through mode, which has known deviations in RMCP+ from the IPMI
specification.
2014-11-29 17:26:48 +01:00
Jim Mankovich
342f44b9f3
Update ChangeLog for 1.8.15 rleease
IPMITOOL_1_8_15
2014-11-24 06:40:17 -07:00
Jim Mankovich
e1c7b532bd
Release Version 1.8.15
2014-11-24 06:30:52 -07:00
Jim Mankovich
3314024867
Remove debian from extra distribution rule for make dist
IPMITOOL_1_8_15RC1
2014-10-23 14:27:06 -06:00
Jim Mankovich
15499d014f
Update ChangeLog for 1.8.15RC1
2014-10-23 14:02:38 -06:00
Zdenek Styblik
21fbd0e967
ID#340 - ipmitool sol session improperly closes on packet retry
...
Commit for Pat Donlin
2014-10-17 20:14:12 +02:00
Zdenek Styblik
deb9a4ed5d
ID#277 - support for hostnames longer than 64 chars
...
ID#313 ipmitool doesn't support hostname long than 64 symbols
ID#277 Minor issue with ipmi_intf_session_set_hostname()
Commit adds support pretty much for FQDN not just up to the length of one label.
This is achieved by change in in struct ipmi_session; and strdup() of user
input. Of course, we have to free() this once we're done.
2014-10-17 19:33:37 +02:00
Zdenek Styblik
58837647c2
lib/ipmi_kontronoem.c - clean up formatting, code
...
Commit cleans up formatting in 'lib/ipmi_kontronoem.c'. Also, it adds some error
messages and fixes return codes.
2014-09-21 09:36:14 +02:00
Zdenek Styblik
5c85c7bc61
ID: 247 - 'sensor thresh' help output is wrong
...
Fix invalid help output by copy-pasting part of 'sensor thresh help'.
2014-09-20 18:21:23 +02:00
Zdenek Styblik
aa8bac2da2
Rename printf_sensor_get_usage() -> print_sensor_get_usage()
2014-09-20 18:07:23 +02:00
Zdenek Styblik
2b15969dcb
Put 'sensor thresh help' into function
...
Move help text for 'sensor thresh help' into its own function.
2014-09-20 18:05:04 +02:00
Zdenek Styblik
7560d4f2f4
ID: 324 - conflicting declaration write_fru_area()
...
Commit fixes conflicting declarations of write_fru_area().
Author: Jörg Frings-Fürst
2014-09-20 15:43:30 +02:00
Zdenek Styblik
859e8a4576
ID: 337 - Add support for 13G Dell PowerEdge
...
Description: Add support for Dell 13G server.
Add support for upcoming Dell PowerEdge 13G server
and replace multiple if statments.
Based on patch from SriniG <srinivas_g_gowda@dell.com>
Author: Jörg Frings-Fürst <debian@jff-webhosting.net>
Origin: based on patch from SriniG <srinivas_g_gowda@dell.com>
Bug: http://sourceforge.net/p/ipmitool/patches/102/
Bug-debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=756555
Forwarded: http://sourceforge.net/p/ipmitool/patches/102/
Reviewed-by: 2014-08-07 SriniG <srinivas_g_gowda@dell.com>
2014-09-20 15:30:55 +02:00
Parthasarathy Bhuvaragan
f49c9eec53
print message header and data in verbose print
...
Change-Id: I613e35e180c815279d2a50f44956a5ed5bf5461b
Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.xx.bhuvaragan@ericsson.com>
2014-09-03 10:01:07 +02:00
Parthasarathy Bhuvaragan
a6f34c9029
fix incorrect data validation
...
Change-Id: I6c277b4716445e8ae9a6851cca48e1ad95df49b4
Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.xx.bhuvaragan@ericsson.com>
2014-09-03 09:53:56 +02:00
Parthasarathy Bhuvaragan
bee3fda656
update result ptr before return
...
Change-Id: If976f5c769d8ba83eefa1693e6969ef17f357ba8
Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.xx.bhuvaragan@ericsson.com>
2014-09-03 09:44:57 +02:00
Parthasarathy Bhuvaragan
737b801768
delete duplicate macros
...
Change-Id: Ie219c955c4644b8ab9822fd1e5523d70038b5261
Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.xx.bhuvaragan@ericsson.com>
2014-09-03 09:42:11 +02:00
Jim Mankovich
96b19bb62d
ID: 325 DDR4 DIMM Decoding Logic
...
Bug 325 was associated with identification of DDR4 SDRAM, but correct decoding
logic was necessary to actually support DDR4 decode. This commit adds the
necessary logic to decode and display DDR4 DIMMS.
2014-08-13 07:12:42 -06:00
Jim Mankovich
9372d2e34e
ID: 328 HPM.2 fixes
...
Fix commited for Dmitry Bazhenov
2014-08-11 11:21:23 -06:00
Jim Mankovich
9babab10f3
ID: 329 hpm.1 upgrade fixes
...
Fix commited for Dmitry Bazhenov
2014-08-11 11:17:41 -06:00
Jim Mankovich
58d510f90f
ID : 103 picmg discover messages should be DEBUG, not INFO
...
Changed picmg discover messages to LOG_DEBUG
2014-08-11 10:49:10 -06:00
Jim Mankovich
ea49700ec1
ID: 331 Passwords provided in file (-f option) truncated on space
...
Code changed to remove truncation on space since space is valid in a password
2014-08-11 10:38:09 -06:00
Jim Mankovich
732be1b968
ID: 325 - Can not identify DDR4 SDRAM
2014-08-11 08:34:58 -06:00
Paul Zirnik
2f57897501
ipmitool delloem: ipmitool delloem extension always return success - fix it
...
The delloem extension functions all return sane error codes, but they
are not used and not passed on. Fix it.
Signed-off-by: Thomas Renninger <trenn@suse.de>
2014-07-08 18:25:53 +02:00
Zdenek Styblik
d79b0e05af
ID: 318 - ipmi_tsol.c: fix buffer overflow
...
Commit fixes buffer over-flow in ipmi_tsol caused by mis-calculation in buffer
size, resp. using wrong variables completely.
2014-05-29 20:19:37 +02:00
Zdenek Styblik
3b15a7c0e2
ID: 306 - "fru print" command prints the FRU #0 twice
...
This patch make the command to spit FRU info #0 only once.
Commit for Dmitry Bazhenov
2014-05-25 08:52:07 +02:00
Zdenek Styblik
3f508629a5
ID: 305 - HPM.1 deferred activation support fixup
...
Currently, the HPM.1 agent in the IPMItool does not differ between Rollback
support and Deferred Activation Support. The patch fixes up this bug.
Commit for Dmitry Bazhenov
2014-05-25 08:48:50 +02:00
Zdenek Styblik
3473670051
lib/ipmi_tsol.c - remove dead code
2014-05-24 10:05:30 +02:00
Zdenek Styblik
aefd287222
lib/ipmi_tsol.c - make code formatting saner
2014-05-24 10:05:05 +02:00