6 Commits

Author	SHA1	Message	Date
Jiang Junyu	6e037d6bfb	Refactor string comparisons ... Clean up use of strcmp/strncmp/strncasecmp for command line arguments. Never use anything but `strcmp()` unless absolutely neccessary. Partialy resolves ipmitool/ipmitool#104	2020-06-10 13:46:57 +03:00
Chrostoper Ertl	41d7026946	session: Fix buffer overflow in ipmi_get_session_info ... Partial fix for CVE-2020-5208, see https://github.com/ipmitool/ipmitool/security/advisories/GHSA-g659-9qxw-p7cp The `ipmi_get_session_info` function does not properly check the response `data_len`, which is used as a copy size, allowing stack buffer overflow.	2020-02-04 14:59:49 +03:00
Alexander Amelkin	e9716e216d	Refactoring: optimize pointer checks ... Remove all direct comparisons to 'NULL' for pointers. Replace them with boolean-like 'if (ptr)' and 'if (!ptr)'. This makes conditions shorter and easier to read. Signed-off-by: Alexander Amelkin <alexander@amelkin.msk.ru>	2018-08-21 17:30:25 +03:00
Alexander Amelkin	9ecfb762bd	Refactoring: get rid of superfluous comparisons ... Make code better readable by replacing `if (rsp->ccode > 0)` and 'if (rsp->ccode != 0)' with just `if (rsp->ccode)` as rsp->ccode is anyway an unsigned byte and can't be negative. Also replace 'if (rsp->ccode == 0)' with 'if (!rsp->ccode)'. All these changes make lines shorter and easier to read as a non-zero ccode is an indication of some failure, and so !ccode naturally reads as 'no error'. Signed-off-by: Alexander Amelkin <alexander@amelkin.msk.ru>	2018-08-21 11:55:03 +03:00
Dmitry Rakhchev	34711329c2	Add mac2str() and str2mac() to print/parse MAC address	2016-07-31 08:52:40 +02:00
Petter Reinholdtsen	c18ec02f33	Move all files one level up in the file hierarcy, to avoid the useless ipmitool directory.	2014-02-05 17:30:32 +01:00