1803 Commits

Author SHA1 Message Date
Zdenek Styblik
0e99dafa12 Merge commit '4c5058cdc33d6be46b3155458df3ba210ea8ad5e' 2015-01-27 08:34:59 +01:00
Gaurav Jain
4c5058cdc3 Replace s6_addr16 with s6_addr since Mac OS X does not have it 2015-01-25 14:56:23 -08:00
Zdenek Styblik
f35ed010f0 Cleanup formatting in ipmi_lan_set_vlan_id() and ipmi_lan_set_vlan_priority() 2015-01-23 18:40:09 +01:00
Zdenek Styblik
512ec41ab4 Fix typo vlan->VLAN in ipmi_lan_set_vlan_id() and ipmi_lan_set_vlan_priority() 2015-01-23 18:40:05 +01:00
Zdenek Styblik
b88a523ded Add limits check in get_cmdline_macaddr()
Commit adds range check prior to cast down to uint8_t. Also, adds a bit of help
text about get_cmdline_macaddr().
2015-01-23 18:30:10 +01:00
Zdenek Styblik
75843864ba Move all help texts into their own functions in ipmi_lanp.c
Commit moves all help texts into their own functions in order to unclutter code
a bit.
2015-01-23 18:18:54 +01:00
Zdenek Styblik
45c54aad0e Add bunch of TODO marks in ipmi_lanp.c 2015-01-23 08:43:15 +01:00
Zdenek Styblik
32c4690950 ID:355 - Fix comparison of unsigned expression
Commit fixes comparison of unsigned expression in ipmi_firewall_reset()
and ipmi_firewall_enable_disable().
2015-01-22 12:55:26 +01:00
Zdenek Styblik
03d8aa1882 ID:355 - Remove defined but unused variable in _set_command_enables() 2015-01-22 12:53:59 +01:00
Zdenek Styblik
d874267e9b ID:361 - Add a OEM IANA information 2015-01-22 12:16:25 +01:00
Zdenek Styblik
c59e7247dd Remove redundant user-input conversion from ipmi_sel_delete()
Commit removes redundant conversion of user input from ipmi_sel_delete(). This
is probably some omitted leftover.
2015-01-22 12:12:38 +01:00
Zdenek Styblik
88891f69d6 Fix big parameter passed by value in ipmi_sel_oem_match() - CID#1261347
Pass struct as a pointer instead.
2015-01-22 06:21:54 +01:00
Zdenek Styblik
aabd9eb1ac ID:355 - Fix zero-length format string warning in get_supermicro_evt_desc() 2015-01-22 06:20:55 +01:00
Zdenek Styblik
82a0caa38b Change formatting of ipmi_sel_oem_match() 2015-01-21 17:47:49 +01:00
Zdenek Styblik
55b1a41855 Fix wrong size argument in ipmi_sdr_list_cache_fromfile() - CID#1149056 2015-01-20 18:58:15 +01:00
Zdenek Styblik
c56458da18 Clenaup formatting in ipmi_sel_show_entry() 2015-01-20 16:30:31 +01:00
Zdenek Styblik
ce3f35d9d9 Fix resource leak in ipmi_kontron_set_serial_number() - CID#1149041 2015-01-19 15:37:05 +01:00
Zdenek Styblik
4dfb15281e Remove dead code in fru_area_print_product() - CID#1148999 2015-01-19 14:47:46 +01:00
Zdenek Styblik
7bd7c4fdd1 Remove dead code in fru_area_print_board() - CID#1149001 2015-01-19 14:46:09 +01:00
Zdenek Styblik
f0acdf1b50 Remove dead code in fru_area_print_chassis() - CID#1149000
I guess this really can't happen.
2015-01-19 14:44:33 +01:00
Zdenek Styblik
ece5e55745 Fix resource leak in fru_area_print_product() - CID#1149046 2015-01-19 06:43:42 +01:00
Zdenek Styblik
99721b52e4 Fix resource leak in fru_area_print_chassis() - CID#1149047 2015-01-19 06:42:05 +01:00
Zdenek Styblik
0b54fac782 Fix resource leak in fru_area_print_board() - CDI#1149048 2015-01-19 06:40:33 +01:00
Zdenek Styblik
312f95930d Fix uninitialized struct in ipmi_fru_upg_ekeying() - CID#1149065 2015-01-19 06:37:07 +01:00
Zdenek Styblik
d36cfcb817 ID:355 - Fix formatting warning in get_cmdline_ipaddr()
Commit also adds validation prior casting down to uint8_t.
2015-01-17 12:25:50 +01:00
Zdenek Styblik
33f9336e85 ID:355 - Fix compiler warnings
Commit removes all unused variables reported by compiler.
2015-01-17 11:44:46 +01:00
Zdenek Styblik
6febd10121 Put functions in ipmi_channel.c in A-Z order 2015-01-17 07:11:07 +01:00
Zdenek Styblik
6b8d55d68b Re-work ccode eval in ipmi_get_channel_medium()
Commit re-works ccode eval in ipmi_get_channel_medium() as the previous one
didn't work and led to dead-code.
2015-01-16 21:05:56 +01:00
Zdenek Styblik
12b85b3c7b Init user_access_t struct in ipmi_user_priv() 2015-01-16 20:49:06 +01:00
Zdenek Styblik
0ff2d6e464 ID:357 - out-of-bound access in DDR4 code
Commit increases RAW_SPD_SIZE from 256 to 512 as an attempt to fix OOB in
ipmi_rawspd_main(), resp. ipmi_spd_print().
2015-01-16 20:18:41 +01:00
Zdenek Styblik
dab7f5bf81 Remove unused variable from ipmi_get_channel_cipher_suites()
Commit removes unused variable oem_record from ipmi_get_channel_cipher_suites().
2015-01-16 20:11:29 +01:00
Zdenek Styblik
6c3f60e57c Remove get_channel_access_rsp and get_channel_info_rsp structs
Commit removes unused structures get_channel_access_rsp and
get_channel_info_rsp as they were replaced.
2015-01-16 20:08:46 +01:00
Zdenek Styblik
278dc84b22 Print error message to STDERR in ipmi_channel.c
Print error message to STDERR and not STDOUT in ipmi_channel_main().
2015-01-16 20:07:26 +01:00
Zdenek Styblik
0801b4588d Hook ipmi_get_channel_medium() to new _ipmi_get_*() functions
Commit hooks ipmi_get_channel_medium() to new _ipmi_get_*() functions.
2015-01-16 20:04:31 +01:00
Zdenek Styblik
56aa025dc2 Hook ipmi_get_channel_info() to _ipmi_get_*()
Commit hooks ipmi_get_channel_info() to new _ipmi_get_*() functions.
2015-01-16 20:03:07 +01:00
Zdenek Styblik
238d3c4ea9 Add _ipmi_get_channel_access() and _ipmi_get_channel_info()
Commit adds _ipmi_get_channel_access() and _ipmi_get_channel_info() as well as
supporting structures.
2015-01-16 20:01:50 +01:00
Zdenek Styblik
69f668309b ipmi_get_user_access() - change var name 'userid' to 'user_id'
Commit changes variable/param name from 'userid' to 'user_id' in order to keep
consistency.
2015-01-13 13:36:25 +01:00
Zdenek Styblik
585cb7c83d Add documentation to 'getaccess' and 'setaccess' functions 2015-01-11 09:39:13 +01:00
Zdenek Styblik
708be8bc45 Hook ipmi_user_priv() to _ipmi_set_user_access()
Commit hooks ipmi_user_priv() to _ipmi_set_user_access(). Later got extended for
'change_priv_limit_only', because of the former.
Commit removes ipmi_user_set_userpriv(), because it's not used anywhere.
2015-01-09 12:48:35 +01:00
Zdenek Styblik
d6deeb264e Hook ipmi_print_user_list() and friends to _ipmi_* functions
Commit hooks ipmi_print_user_list() and related functions to new _ipmi_*
functions. It also removes old/unused functions and user_access_rsp struct.
2015-01-09 11:40:52 +01:00
Zdenek Styblik
bcb96209c5 ID:355 - Fix compiler warnings in dimm_spd.c
* remove unused variable
* add (...) as suggested
2015-01-09 08:00:07 +01:00
Zdenek Styblik
8227384c02 ID: 355 - Fix compiler warnings for Dummy Interface
Commit fixes compiler warnings for Dummy Interface:
* fix variable name
* remove unused variables
2015-01-09 07:31:55 +01:00
Zdenek Styblik
39fb1af285 ID:355 - Fix Enumeration value not handled in ipmi_get_event_desc()
Commit fixes ``Enumeration value not handled'' in ipmi_get_event_desc() by
adding 'default' to the switch.
2015-01-09 07:23:05 +01:00
Zdenek Styblik
faae8fd247 Fix identical code for diff branches in DellOEM - CID#1261326
Commit adds error messages in order to fix CID#1261326.
2015-01-09 07:01:51 +01:00
Zdenek Styblik
b6ec5072f4 Remove length checks in get_supermicro_evt_desc()
Commit removes length checks in get_supermicro_evt_desc(), because they make no
sense. Fixes out-of-bound-reads CID#1149029 and CID#1149030
2015-01-08 22:44:55 +01:00
Zdenek Styblik
fb36c69391 ipmi_print_user_summary() to utilize _ipmi_get_user_access()
Commit changes ipmi_print_user_summary() to utilize _ipmi_get_user_access() and
user_access_t instead of user_access_rsp.
2015-01-08 21:54:41 +01:00
Zdenek Styblik
d099dca9c5 Fix/remove pointer cast in _ipmi_set_user_access()
Commit removes invalid pointer in _ipmi_set_user_access().
2015-01-08 21:29:30 +01:00
Zdenek Styblik
af276d4082 Fix out-of-bound-reads in get_supermicro_evt_desc()
CID#1149029 and CID#1149030
2015-01-08 20:22:15 +01:00
Zdenek Styblik
e4be291c65 Re-work 'channel getaccess' and 'channel setaccess'
Commit is a re-work of 'channel getaccess' and 'channel setaccess'. These are
using _ipmi_* now. Also, bitfields and two structs are replaced by one unified
struct.
2015-01-08 19:45:22 +01:00
Zdenek Styblik
bb35d370ba Add eval_ccode() into helper
Commit adds eval_ccode() into helper in order to save some code repetition on
evaluation of retvals from _ipmi_* functions.
2015-01-08 19:43:27 +01:00