Alexander Rube
3412d86143
ID:391 - changing data_len from 17 to 16 according to ipmi spec 22.29, first byte is completion code
2015-09-11 06:09:49 +02:00
Zdenek Styblik
a98eedb272
Remove trailing white-spaces in ipmi_user.c
2015-09-11 06:09:25 +02:00
Zdenek Styblik
372b458e0f
ID:388 - Fix Error message always printed if BMC does not support VITA
...
Print error message for 0xC1 to LOG_DEBUG instead of LOG_ERR, because it isn't
an error if VITA isn't supported.
2015-09-11 06:00:44 +02:00
Alexander Rube
0caa68115e
ID:389 - Add on of Advantech IANA number
2015-09-02 08:49:35 +02:00
Zdenek Styblik
a5c1120dbb
Cleanup trailing white-spaces in ipmi_vita.c
2015-08-26 09:18:35 +02:00
Dmitry Bazhenov
89e9e63443
ID:376 - Add means to configure "Bad Password Threshold"
...
Add support for setting and printing of the "Bad Password Threshold"
LAN configuration parameter.
2015-08-06 07:28:54 +02:00
Zdenek Styblik
ff80a188f3
ID:382 - Fix memcpy() params in HpmFwupgActionUploadFirmware()
...
The 'bufLength' variable holds a constant chunk size. If the actual
data length is less than the 'bufLength', then it crashes IPMITool. The
code was already there to calculate the remaining data length, but was
not used in memcpy(). We changed it to use the 'count' variable which
holds the proper available data length.
Commit for: Viswanathan Swaminathan
2015-07-27 06:37:37 +02:00
Zdenek Styblik
c87aa0b96a
ID:368 - Fix handling of bridging-related parameters
...
1. my_addr is not set if an interface does not expose set_my_addr.
Currently, the only interface which requires some special handling to set
my_addr is OpenIPMI. But changing of my_addr still needed for other interfaces.
So, we must set it regardless of presence of set_my_addr().
2. Since set_my_addr() for serial interfaces only sets my_addr, we remove them
as redundand.
3. Bridging is enabled when either trasit_addr or target_addr is not 0.
Currentle transit_addr is not regarded.
4. target_lun does not relate to briging. It is needed for "raw" command. We
set it regardles of bridging.
Commit for: Dmitry Bazhenov
2015-07-25 13:03:37 +02:00
Zdenek Styblik
2d79e69f5f
Merge commit '2f5789750183d4ef8be125b8cb32019441dd0530'
...
Return codes of functions should be either used or evaluated - always. This
merge is necessary for shell scripting to, eg. signal there was an error during
execution.
2015-07-25 10:16:38 +02:00
Pat Donlin
259500e127
ID: 380 raw commands override retry and timeout values
...
Remove the hard coded override for retry and timeout in ipmi_master_write_read
2015-07-25 09:43:57 +02:00
Pat Donlin
70099a3c40
ID: 380 - raw commands override retry and timeout values
...
Correct compiler warnings in ipmi_raw.c
2015-07-25 09:43:51 +02:00
Zdenek Styblik
eb54136775
ID:319 - Interface safe re-open
...
Currently, interface-management code in the ipmitool does not allow safe
interface re-opening (i.e. closing and opening again). It is because the session
is allocated in the interface setup callback while is freed in the close
callback. So, normal re-opening of the interface, which can be required for
example durng the HPM.1 upgrade, leads to segmentation fault. That's why in the
ipmi_hpmfwupg.c instead of normal closing interface, directly access the
interface data for subsequent re-opening.
Commit for Dmitry Bazhenov
2015-03-11 19:41:34 +01:00
Parthasarathy Bhuvaragan
9caa78be38
ID:371 - add ericsson oem
...
Change-Id: I4fa230b2388e83ae0bc560539675d4dd8783a33e
Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.xx.bhuvaragan@ericsson.com>
2015-02-17 15:43:03 +01:00
Pat Donlin
ce861658c0
Node Manager Feature, correct 1268194 missing break.
2015-02-17 14:51:44 +01:00
Zdenek Styblik
f1c6118c72
ID:320 - Add VITA 46.11 support
...
Commit adds support for VITA 46.11 by Dmitry Bazhenov.
2015-02-05 18:43:49 +01:00
Zdenek Styblik
d5c2e976d4
ID:355 - remove unused variables from ipmi_dcmi.c
...
I'd swear I've already removed those, hmm.
2015-02-05 18:37:07 +01:00
Pat Donlin
7a854623aa
ID:363 - fix Coverity issues in NM implementation
...
Commit fixes issues pointed out by Coverity.
2015-02-05 18:32:06 +01:00
Pat Donlin
fd5fdc59f2
ID:363 - Node Manager feature patch.
2015-02-05 18:31:07 +01:00
Zdenek Styblik
4725cfd6d9
Hook ipmi_set_alert_enable() to _ipmi_*()
...
Commit hooks ipmi_set_alert_enable() to _ipmi_*() functions and is sort of
rewrite of that function with the same functionality.
2015-02-03 11:47:38 +01:00
Zdenek Styblik
5a30d18af2
_ipmi_set_channel_access() - zero-out variable data before use
2015-02-03 11:45:59 +01:00
Zdenek Styblik
11bbf18345
Rewrite ipmi_set_channel_access()
...
Commit is a rewrite of ipmi_set_channel_access(). Function utilizes _ipmi_*()
functions now in order to avoid code repetition. Other than that, functionality
should remain the same.
2015-02-03 07:42:10 +01:00
Zdenek Styblik
026a8b6fce
Add _ipmi_set_channel_access() function
...
Commit adds _ipmi_set_channel_access() function which in implementation of
(22.22) Set Channel Access Command.
2015-02-03 07:33:08 +01:00
Zdenek Styblik
410606e868
Hook ipmi_set_user_access() to _ipmi_set_user_access()
...
Commit hooks ipmi_set_user_access() to _ipmi_set_user_access() and removes
duplicate code.
2015-01-30 13:16:44 +01:00
Zdenek Styblik
8081427543
_ipmi_set_user_password() - fix missing intf parameter in documentation
2015-01-30 13:15:36 +01:00
Zdenek Styblik
8f1f31cfdc
Remove ipmi_user_set_password()
...
Commit removes ipmi_user_set_password() as it's not being used anywhere.
2015-01-30 07:53:03 +01:00
Zdenek Styblik
90e2134413
Hook ipmi_lan_set_password() to _ipmi_set_user_password()
...
Commit hooks ipmi_lan_set_password() to _ipmi_set_user_password() in order to
get rid off code duplication.
2015-01-30 07:47:52 +01:00
Zdenek Styblik
66eee40df4
Hook functions in ipmi_user to _ipmi_set_user_password()
...
Commit hooks functions in ipmi_user to _ipmi_set_user_password() instead of
ipmi_user_set_password().
2015-01-30 07:46:39 +01:00
Zdenek Styblik
a6d47ceba4
Add _ipmi_set_user_password() function
...
Commit adds _ipmi_set_user_password() which is implementation of (22.30) Set
User Command. Function doesn't print anything on stdout/stderr.
2015-01-30 07:33:04 +01:00
Zdenek Styblik
21151953a5
Move #define from ipmi_user.c to ipmi_user.h
...
Commit moves defines of Set User Password operations to header file.
2015-01-30 07:08:57 +01:00
Zdenek Styblik
b591bc2ab7
Handle more retcodes in eval_ccode()
2015-01-30 07:04:39 +01:00
Zdenek Styblik
f35ed010f0
Cleanup formatting in ipmi_lan_set_vlan_id() and ipmi_lan_set_vlan_priority()
2015-01-23 18:40:09 +01:00
Zdenek Styblik
512ec41ab4
Fix typo vlan->VLAN in ipmi_lan_set_vlan_id() and ipmi_lan_set_vlan_priority()
2015-01-23 18:40:05 +01:00
Zdenek Styblik
b88a523ded
Add limits check in get_cmdline_macaddr()
...
Commit adds range check prior to cast down to uint8_t. Also, adds a bit of help
text about get_cmdline_macaddr().
2015-01-23 18:30:10 +01:00
Zdenek Styblik
75843864ba
Move all help texts into their own functions in ipmi_lanp.c
...
Commit moves all help texts into their own functions in order to unclutter code
a bit.
2015-01-23 18:18:54 +01:00
Zdenek Styblik
45c54aad0e
Add bunch of TODO marks in ipmi_lanp.c
2015-01-23 08:43:15 +01:00
Zdenek Styblik
32c4690950
ID:355 - Fix comparison of unsigned expression
...
Commit fixes comparison of unsigned expression in ipmi_firewall_reset()
and ipmi_firewall_enable_disable().
2015-01-22 12:55:26 +01:00
Zdenek Styblik
03d8aa1882
ID:355 - Remove defined but unused variable in _set_command_enables()
2015-01-22 12:53:59 +01:00
Zdenek Styblik
d874267e9b
ID:361 - Add a OEM IANA information
2015-01-22 12:16:25 +01:00
Zdenek Styblik
c59e7247dd
Remove redundant user-input conversion from ipmi_sel_delete()
...
Commit removes redundant conversion of user input from ipmi_sel_delete(). This
is probably some omitted leftover.
2015-01-22 12:12:38 +01:00
Zdenek Styblik
88891f69d6
Fix big parameter passed by value in ipmi_sel_oem_match() - CID#1261347
...
Pass struct as a pointer instead.
2015-01-22 06:21:54 +01:00
Zdenek Styblik
aabd9eb1ac
ID:355 - Fix zero-length format string warning in get_supermicro_evt_desc()
2015-01-22 06:20:55 +01:00
Zdenek Styblik
82a0caa38b
Change formatting of ipmi_sel_oem_match()
2015-01-21 17:47:49 +01:00
Zdenek Styblik
55b1a41855
Fix wrong size argument in ipmi_sdr_list_cache_fromfile() - CID#1149056
2015-01-20 18:58:15 +01:00
Zdenek Styblik
c56458da18
Clenaup formatting in ipmi_sel_show_entry()
2015-01-20 16:30:31 +01:00
Zdenek Styblik
ce3f35d9d9
Fix resource leak in ipmi_kontron_set_serial_number() - CID#1149041
2015-01-19 15:37:05 +01:00
Zdenek Styblik
4dfb15281e
Remove dead code in fru_area_print_product() - CID#1148999
2015-01-19 14:47:46 +01:00
Zdenek Styblik
7bd7c4fdd1
Remove dead code in fru_area_print_board() - CID#1149001
2015-01-19 14:46:09 +01:00
Zdenek Styblik
f0acdf1b50
Remove dead code in fru_area_print_chassis() - CID#1149000
...
I guess this really can't happen.
2015-01-19 14:44:33 +01:00
Zdenek Styblik
ece5e55745
Fix resource leak in fru_area_print_product() - CID#1149046
2015-01-19 06:43:42 +01:00
Zdenek Styblik
99721b52e4
Fix resource leak in fru_area_print_chassis() - CID#1149047
2015-01-19 06:42:05 +01:00