1437 Commits

Author SHA1 Message Date
Zdenek Styblik
ca062647be Adds use of str2NUM() functions for the most of user input parameters in
'lib/main.c'. Error messages added as well.
2012-01-25 15:27:13 +00:00
Zdenek Styblik
3423c1d92f 'lib/helper.c' - str2uchar() - renamed arg_long -> arg_ulong 2012-01-25 15:09:49 +00:00
Zdenek Styblik
e0b75fba8c Adds function str2uint() to convert string to uint16_t with checks for valid input. 2012-01-25 14:57:12 +00:00
Zdenek Styblik
7dd969f2c6 Replaces use of atoi() for parameters d, p and C with str2int() function and
adds range validation for these parameters.
2012-01-25 12:56:36 +00:00
Zdenek Styblik
a9c68c76c3 Remove extra new-lines from error messages in 'src/ipmievd.c'. 2012-01-25 12:08:46 +00:00
Zdenek Styblik
e29166e4e8 Add input validation for time-out parameter in 'src/ipmievd.c'. 2012-01-25 11:53:41 +00:00
Zdenek Styblik
9217312cc4 Fixes missing return for selwatch_wait() in 'src/ipmievd.c'.
Added return 0;''.
2012-01-25 09:12:42 +00:00
Zdenek Styblik
fbf75dd075 Adds check whether PID fp was acquired or not. If not, then init logging
facility, print error and exit.
2012-01-25 09:02:59 +00:00
Zdenek Styblik
bf1e9952e1 Fixes ignorance of existing PID file which results in PID being overwritten.
Start of the daemon has shifted couple lines bellow, because it doesn't make
sense to start daemon first and check existence of PID file later.
2012-01-24 13:59:58 +00:00
Zdenek Styblik
5ed7f6ac0a Fixes CVE-2011-4339 - world writeable PID file
Adds proper umask() before writing PID file.
2012-01-24 13:26:56 +00:00
Zdenek Styblik
b6d2f7e302 Commit introduces set of functions to safely convert user input to numbers.
These functions utilize strtol() and strtoul() to convert input and check for
invalid input as well as for *flows.

Functions added: str2long(), str2ulong(), str2int(), str2short(), str2uchar();
2012-01-24 12:14:21 +00:00
Zdenek Styblik
bb40822d34 Replace whitespace indentations with tabs in 'lib/helper.c'. 2012-01-21 08:31:09 +00:00
Zdenek Styblik
835fe8886c Replace whitespaces with tabs, remove trailing spaces/tabs and other formatting inconsistencies. 2012-01-21 07:19:52 +00:00
Zdenek Styblik
55ee48696a Remove hardcoded CR('\r') from 'lib/ipmi_delloem.c'. 2012-01-21 05:38:49 +00:00
Zdenek Styblik
fedd6f187f Remove hardcoded CR('\r') from 'lib/ipmi_ekanalyzer.c'. 2012-01-21 05:37:41 +00:00
Zdenek Styblik
a6cad674d0 Remove hardcoded CR('\r') from 'lib/ipmi_fru.c'. 2012-01-21 05:36:58 +00:00
Zdenek Styblik
c1e46b35cd Remove hardcoded CR('\r') from 'lib/ipmi_fwum.c'. 2012-01-21 05:35:49 +00:00
Zdenek Styblik
a65d5add66 Remove hardcoded CR('\r') from 'lib/ipmi_hpmfwupg.c'. 2012-01-21 05:34:33 +00:00
Zdenek Styblik
ba6f2fe2a2 Remove hardcoded CR('\r') from 'lib/ipmi_isol.c'. 2012-01-21 05:32:24 +00:00
Zdenek Styblik
ebab3919ef Remove hardcoded CR('\r') from 'lib/ipmi_kontronoem.c'. 2012-01-21 05:31:16 +00:00
Zdenek Styblik
e6db6a04b5 Remove hardcoded CR('\r') from 'lib/ipmi_main.c'. 2012-01-21 05:29:41 +00:00
Zdenek Styblik
fb75f8d8fc Remove hardcoded CR('\r') from 'lib/ipmi_picmg.c'. 2012-01-21 05:28:39 +00:00
Zdenek Styblik
9660e90ad2 Remove hardcoded CR('\r') from 'lib/ipmi_sol.c'. 2012-01-21 05:27:14 +00:00
Zdenek Styblik
e0ed4351d0 Remove hardcoded CR('\r') from 'lib/ipmi_tsol.c'. 2012-01-21 05:26:23 +00:00
Zdenek Styblik
619233e14b Remove hardcoded CR('\r') from 'lib/log.c'. 2012-01-21 05:24:19 +00:00
Zdenek Styblik
7c9baca424 Remove hardcoded CR('\r') from 'lib/helper.c'. 2012-01-21 05:23:22 +00:00
Zdenek Styblik
c9b53b1b32 Fix possible buffer overflow in buf2str() in 'lib/helper.c'. 2012-01-20 19:19:22 +00:00
Zdenek Styblik
54cc84adf2 Fix typo in 'picmg power get help' output. Replaces 'powert' with 'power'. 2012-01-20 18:57:14 +00:00
Zdenek Styblik
37d672412d Remove unused variable in 'lib/ipmi_chassis.c' 2012-01-20 18:51:24 +00:00
Jean-Michel Audet
1b1efca7e2 - Bug in the existing code where it keeps on adding same command/seq pair
- Add timeout / retry to LAN
-- Thanks to Harshad Parbhu --
2011-11-22 13:43:38 +00:00
Jean-Michel Audet
c9bd5b5b90 - Bug in the existing code where it keeps on adding same command/seq pair
- Add retry / timeout options for LAN
2011-11-22 13:42:36 +00:00
Jordan Hargrave
19295a5483 Add new Dell OEM commands and update man page 2011-10-06 16:26:18 +00:00
Jordan Hargrave
d06ddcd28b Add Dell OEM network commands 2011-09-21 20:59:04 +00:00
Jean-Michel Audet
335d444213 - Clarify DCMI get limit activation (add if activate or not).
- Change some string to remove underscore (was looking more like coding style string)
2011-08-26 18:57:18 +00:00
Jean-Michel Audet
0cbc38746a - Add DCMI module (Data Center Management Interface)
* Module retreive from application DCMITool that is originally based on IPMITool.
* File ipmi_dcmi.c does not have a restrictive license and as per the license on
* the top of the file, the software is provided "AS IS".
2011-06-28 13:50:59 +00:00
Jean-Michel Audet
348cd98287 - Add support for AMC type 17h record. 2011-05-17 13:20:06 +00:00
Jordan Hargrave
eb22beb537 Add support for drive backplane SetLED functionality 2011-04-14 20:23:59 +00:00
Marie-Josee Blais
019a9de626 Re-adding C3 fix 2011-03-30 19:52:38 +00:00
Marie-Josee Blais
c5c6315525 Improvement to hpm upgrade during activation. This resolves issue where activation seems to have failed because ipmitool received an unsupported completion code. 2011-03-10 19:01:35 +00:00
Marie-Josee Blais
7fc4ce6eae Fix in fru edit
It is now possible to edit field 0 of sections
2011-03-08 19:38:03 +00:00
Marie-Josee Blais
061272f595 - Fixed issues with fru edit.
Allocated memory for fru is cleared.
Added check to prevent copying data from old fru beyond end of allocated memory
Code now keeps track of old and new product section length. Used to determine position of remaining bytes.
2011-03-08 16:17:58 +00:00
Jean-Michel Audet
fab9a60f71 - Re-enable SDR reading for non-ipmb devices 2011-03-03 13:41:31 +00:00
Duncan Laurie
3e2211dc47 Testing commit as it is failing for some people. 2011-03-01 23:09:12 +00:00
Jordan Hargrave
f798f74234 Add skeleton for Dell OEM setled functionality 2010-12-14 06:41:31 +00:00
Jordan Hargrave
74e2376bf9 Add build support for Dell OEM commands 2010-11-04 21:04:21 +00:00
Jordan Hargrave
2f1773a819 Add files to support Dell OEM IPMI commands 2010-11-04 21:03:08 +00:00
Jean-Michel Audet
9ab06ee09e - Add possibility to resize FRU strings with command ipmitool fru edit 0 ... 2010-08-23 17:29:40 +00:00
Marie-Josee Blais
94e47fb2c6 Improvements large packet command code 2010-08-11 17:14:33 +00:00
Marie-Josee Blais
13bb060366 Fixes for multi-latform support.
Fix for timeouts during firmware rollback. If completion code is C3, wait till timeout has expired before reporting it.
2010-08-11 17:13:21 +00:00
Marie-Josee Blais
fdf49777b9 Increased variable size of timeouts.
During manual rollback, code now gets target capabilities instead of using a default timeout of 60 seconds.
2010-08-10 15:34:00 +00:00