update regarding modules, lint and expand puppet manifest.

Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>

windows/security/threat-protection/microsoft-defender-atp/linux-install-with-puppet.md

@@ -1,6 +1,6 @@
 ---
 title: Deploy Microsoft Defender ATP for Linux with Puppet
-ms.reviewer: 
+ms.reviewer:
 description: Describes how to deploy Microsoft Defender ATP for Linux using Puppet.
 keywords: microsoft, defender, atp, linux, installation, deploy, uninstallation, puppet, ansible, linux, redhat, ubuntu, debian, sles, suse, centos
 search.product: eADQiWindows 10XVcnh
@@ -14,7 +14,7 @@ author: dansimp
 ms.localizationpriority: medium
 manager: dansimp
 audience: ITPro
-ms.collection: M365-security-compliance 
+ms.collection: M365-security-compliance
 ms.topic: conceptual
 ---
 
@@ -48,7 +48,7 @@ Download the onboarding package from Microsoft Defender Security Center:
     ![Microsoft Defender Security Center screenshot](images/atp-portal-onboarding-linux-2.png)
 
 4. From a command prompt, verify that you have the file. Extract the contents of the archive:
-  
+
     ```bash
     $ ls -l
     total 8
@@ -60,7 +60,7 @@ Download the onboarding package from Microsoft Defender Security Center:
 
 ## Create a Puppet manifest
 
-You need to create a Puppet manifest for deploying Microsoft Defender ATP for Linux to devices managed by a Puppet server. This example makes use of the *apt* module available from puppetlabs, and assumes that the apt module has been installed on your Puppet server.
+You need to create a Puppet manifest for deploying Microsoft Defender ATP for Linux to devices managed by a Puppet server. This example makes use of the *apt* and *yumrepo* module available from puppetlabs, and assumes that the modules has been installed on your Puppet server.
 
 Create the folders *install_mdatp/files* and *install_mdatp/manifests* under the modules folder of your Puppet installation. This is typically located in */etc/puppetlabs/code/environments/production/modules* on your Puppet server. Copy the mdatp_onboard.json file created above to the *install_mdatp/files* folder. Create an *init.pp* file that contains the deployment instructions:
 
@@ -86,44 +86,63 @@ In order to preview new features and provide early feedback, it is recommended t
 
 Note your distribution and version and identify the closest entry for it under `https://packages.microsoft.com/config/`.
 
-In the below commands, replace *[distro]* and *[version]* with the information you've identified:
-
-> [!NOTE]
-> In case of Oracle EL and CentOS 8, replace *[distro]* with “rhel”.
-
 ```puppet
-class install_mdatp {
+# Puppet manifest to install Microsoft Defender ATP.
+# @param channel The release channel based on your environment, insider-fast or prod.
+# @param distro The Linux distribution in lowercase. In case of RedHat, Oracle EL and CentOS 8, the distro variable should be 'rhel'.
+# @param version The Linux distribution release number, e.g. 7.4.
 
-    if ($osfamily == 'Debian') {
+class install_mdatp (
-        apt::source { 'microsoftpackages' :
+$channel = 'insiders-fast',
-            location => 'https://packages.microsoft.com/[distro]/[version]/prod', # change the version and distro based on your OS 
+$distro = undef,
-            release  => '[channel]',
+$version = undef
-            repos    => 'main',
+){
-            key      => {
+    case $::osfamily {
-                'id'     => 'BC528686B50D79E339D3721CEB3E94ADBE1229CF',
+        'Debian' : {
-                'server' => 'https://packages.microsoft.com/keys/microsoft.asc',
+            apt::source { 'microsoftpackages' :
-            },
+                location => "https://packages.microsoft.com/${distro}/${version}/prod",
+                release  => $channel,
+                repos    => 'main',
+                key      => {
+                    'id'     => 'BC528686B50D79E339D3721CEB3E94ADBE1229CF',
+                    'server' => 'keyserver.ubuntu.com',
+                },
+            }
         }
-    }
+        'RedHat' : {
-    else {
+            yumrepo { 'microsoftpackages' :
-        yumrepo { 'microsoftpackages' :
+                baseurl  => "https://packages.microsoft.com/${distro}/${version}/${channel}",
-            baseurl  => 'https://packages.microsoft.com/[distro]/[version]/[channel]', # change the version and distro based on your OS 
+                enabled  => 1,
-            enabled  => 1,
+                gpgcheck => 1,
-            gpgcheck => 1,
+                gpgkey   => 'https://packages.microsoft.com/keys/microsoft.asc'
-            gpgkey   => 'https://packages.microsoft.com/keys/microsoft.asc'
+            }
         }
+        default : { fail("${::osfamily} is currently not supported.") }
     }
 
-    package { 'mdatp':
+    case $::osfamily {
-        ensure => 'installed',
+        /(Debian|RedHat)/: {
-    }
+            file { ['/etc/opt', '/etc/opt/microsoft', '/etc/opt/microsoft/mdatp']:
+                ensure => directory,
+                owner  => root,
+                group  => root,
+                mode   => '0755'
+            }
 
-    file { ['/etc', '/etc/opt', '/etc/opt/microsoft', '/etc/opt/microsoft/mdatp']:
+            file { '/etc/opt/microsoft/mdatp/mdatp_onboard.json':
-        ensure => directory,
+                source  => 'puppet:///modules/mdatp/mdatp_onboard.json',
-    }
+                owner   => root,
-    file { '/etc/opt/microsoft/mdatp/mdatp_onboard.json':
+                group   => root,
-        mode => "0644",
+                mode    => '0600',
-        source => 'puppet:///modules/install_mdatp/mdatp_onboard.json',
+                require => File['/etc/opt/microsoft/mdatp']
+            }
+
+            package { 'mdatp':
+                ensure  => 'installed',
+                require => File['/etc/opt/microsoft/mdatp/mdatp_onboard.json']
+            }
+        }
+        default : { fail("${::osfamily} is currently not supported.") }
     }
 }
 ```