deepblue/ipmitool
1
0
Fork 0
mirror of https://github.com/ipmitool/ipmitool.git synced 2025-05-10 18:47:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

ID:354 - uint8_t >= 0 is always true, don't test it

Browse Source 
Commit removes test whether value is greater or equal to 0 in
is_ipmi_channel_num(), because it's always true(and it makes compiler mad).
This commit is contained in:
Zdenek Styblik 2014-12-23 14:22:00 +01:00
parent 6ca88cb687
commit 148d0e0904
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/helper.c
View File

@ -719,7 +719,7 @@ is_ipmi_channel_num(const char *argv_ptr, uint8_t *channel_ptr)
return (-1); return (-1);
} }
if ((str2uchar(argv_ptr, channel_ptr) == 0) if ((str2uchar(argv_ptr, channel_ptr) == 0)
&& ((*channel_ptr >= 0x0 && *channel_ptr <= 0xB) && (*channel_ptr <= 0xB
|| (*channel_ptr >= 0xE && *channel_ptr <= 0xF))) { || (*channel_ptr >= 0xE && *channel_ptr <= 0xF))) {
return 0; return 0;
} }