deepblue/ipmitool
1
0
Fork 0
mirror of https://github.com/ipmitool/ipmitool.git synced 2025-05-11 19:17:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Change return type and value of find_lan_channel() in 'lib/ipmi_lanp.c'

Browse Source 
Changes return type from int to uint8 since returned value is being assigned
into uint8_t.
Changes return value from (-1) to 0, because of uint8_t. 0 is considered as an
invalid LAN channel anyway, so there is no reason for returning (-1).
This commit is contained in:
Zdenek Styblik 2012-02-08 14:42:47 +00:00
parent 29d82210b4
commit 4a462cd714
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
ipmitool/lib/ipmi_lanp.c
View File

@ -83,22 +83,22 @@ is_lan_channel(struct ipmi_intf * intf, uint8_t chan)
/* find_lan_channel - Find first channel that is LAN /* find_lan_channel - Find first channel that is LAN
* *
* return channel number if successful * return channel number if successful
* return -1 if no lan channel found * return 0 if no lan channel found, which is not a valid LAN channel
* *
* @intf: ipmi interface handle * @intf: ipmi interface handle
* @start: channel number to start searching from * @start: channel number to start searching from
*/ */
static int static uint8_t
find_lan_channel(struct ipmi_intf * intf, int start) find_lan_channel(struct ipmi_intf * intf, uint8_t start)
{ {
uint8_t chan; uint8_t chan = 0;
for (chan = start; chan < IPMI_CHANNEL_NUMBER_MAX; chan++) { for (chan = start; chan < IPMI_CHANNEL_NUMBER_MAX; chan++) {
if (is_lan_channel(intf, chan)) { if (!is_lan_channel(intf, chan)) {
return chan; return chan;
} }
} }
return -1; return 0;
} }
/* get_lan_param_select - Query BMC for LAN parameter data /* get_lan_param_select - Query BMC for LAN parameter data